This commit allows the user to clear clips from the Luppp grid
with a MIDI message. The binding method is very similar to the
existing "grid:event" style, with added to "action" representing
1 for press, and 0 for release, -1 now represents a "clear" event.
As such, the following binding would clear clip track 1, scene 1,
when midi note number 60 had a note on event. Note that the value
for "send" is also set to -1, indicating it is not a send binding.
Active set to -1 indicates that the clip should be cleared:
{
"action": "grid:event",
"status": 144,
"data": 60,
"track": 1,
"scene": 1,
"send": -1,
"active": -1
}
See Github issue #134
Previously when not using NSM, and the project dir ~/luppp/
did not exist, Luppp would fail to save the session as it did
not attempt to create the directory. This patch adds the creating
of the directory if it does not already exist.
This to bring common fomatting to the whole project,
including submissions. To format a file to this style:
astyle --style=linux -t8 <file>
Future patches / pull-requests should be in this format.
Fixes dsp bug in how the master diff was calculated,
which left some room for error and hence some just-not-silence
levels sneak through the fader.
Increase the calculation threshold to be more sensitive, so
there is now 10x less creep. Testing here proved that it never
bleeds audio anymore
[HvH] I modified this commit - a few changes I didn't like, for
example removing the src/config.hxx debug variables - I know they
are commented, but I use the regularly during development to get
extra prints. So this commit removed some of your changes - just
a note that you're not wondering where the changes went :)
Thanks for the PR!
DSP and GUI level defaults for JackSend are now 1, so when
you click the FX button, by default the audio will be routed
to the send, returned, and audible again. This is better UX.
Fixed 2 build warnings to do with string termination
Looks better than before, but still not ideal. Perhaps adding
a global (master) FX send to JACK could fill the space?
Or else re-layout the items (labels under dials?) to fill void.