Commit graph

2482 commits

Author SHA1 Message Date
glacambre
a943081f3b
TSLint: re-enable no-nested-template-literals rule 2019-04-03 13:33:03 +02:00
Oliver Blanthorn
a58b93f9af
Merge pull request #1430 from tridactyl/tslint_rules_reactivation
Tslint rules reactivation
2019-04-03 12:08:41 +01:00
glacambre
270a1dbf9c
TSLint: re-enable no-dead-store rule
No point in storing things that we're not going to use.
2019-04-03 07:45:09 +02:00
glacambre
7240444d9a
TSLint: re-enable no-consecutive-blank-lines rule
Deactivated in excmds.ts as it is used to generate
.excmds_{background,content}.generated.ts which are full of consecutive
blank lines.
2019-04-03 07:17:48 +02:00
glacambre
15b627c340
TSLint: re-enable no-collapsible-if rule
This rule detects unnecessary nesting of if/else statements and tells
you to remove them.
2019-04-03 07:03:03 +02:00
glacambre
cb7c5f2932
TSLint: re-enable no-bitwise rule
Bitwise operations can be confusing so let's not use them.
2019-04-03 06:55:37 +02:00
glacambre
9119944bd9
TSLint: re-enable no-angle-bracket-type-assertion rule
This rule enforces using `x as y` instead of `<y>x` in order to cast
elements. This makes things easier to read and protects against
conflicts with tsx.
2019-04-03 06:33:13 +02:00
Oliver Blanthorn
f1ad4a36b1
Merge pull request #1429 from tridactyl/tslint_rules_reactivation
Tslint rules reactivation
2019-04-02 20:22:28 +01:00
glacambre
2ccd6bd4a4
Fix completions broken by prettier 2019-04-02 18:59:47 +02:00
glacambre
673bf6f280
TSLint: re-enable member-ordering rule
The member-ordering rule enforces declaring public functions before
private functions.
2019-04-02 18:37:02 +02:00
glacambre
f8419b20ed
TSLint: re-enable interface-over-type-literal rule
The interface-over-type-literal rule specifies that object types should
be represented with `interface` instead of `type` if possible.
2019-04-02 18:22:54 +02:00
glacambre
3c9c3867e2
TSLint: re-enable forin rule
The forin rule forbids using the `for (let key in object)` syntax. This
is because iterating with `for in` also iterates over keys obtained from
prototypal inheritance. This is most of the time wrong and using `for
(let key of Object.keys(object)` protects against that.
2019-04-02 18:17:12 +02:00
Oliver Blanthorn
071e5a9eff
Merge pull request #1427 from tridactyl/tslint_rules_reactivation
Tslint rules reactivation
2019-04-02 13:00:32 +01:00
glacambre
7733149e03
messaging.ts: Make sure owntab_background listener is only for bg script 2019-04-02 06:42:57 +02:00
glacambre
8545efdf3f
TSLint: re-enable comment-format rule
This rule requires that all single line comments must start with a
space, i.e. `//hello` is forbidden and `// hello` is allowed.
This made me discover a few pre-processor macro in files that aren't
taken into account by the macro-preprocessor and so I've decided to
remove these directives.
Note that this rule must stay disabled for excmds.ts as it would break
our preprocessor macros.
2019-04-02 06:38:59 +02:00
glacambre
f2630ea047
TSLint: re-enable callable-types rule
This rule specifies that if an interface defines a simple function, it
should be represented as a `type` rather than an `interface`.
2019-04-02 06:16:00 +02:00
Oliver Blanthorn
efdee3c4e8
Merge pull request #1426 from tridactyl/tslint_rules_reactivation
TSLint: re-enable bool-param-default rule
2019-04-01 18:03:33 +01:00
glacambre
f11f5481e2
TSLint: re-enable bool-param-default rule
The bool-param-default rule requires all optional boolean parameters to
have a default value.
2019-04-01 18:06:13 +02:00
Oliver Blanthorn
03d1f183f0
Merge pull request #1425 from tridactyl/tslint_rules_reactivation
TSLint: re-enable ban-types rule
2019-04-01 14:11:53 +01:00
glacambre
8ed07362e0
TSLint: re-enable ban-types rule
This rule disallows using Number, String or Boolean constructors as
types and instead forces using the actual type, `number`, `string` or
`boolean`.
2019-04-01 12:57:19 +02:00
Oliver Blanthorn
5abb5462b7
Merge pull request #1424 from tridactyl/tslint_rules_reactivation
TSLint: re-activate array-type rule
2019-04-01 08:37:35 +01:00
glacambre
f5563c3d3e
TSLint: re-activate array-type rule
This rule stipulates that complex array types should be represented as
Array<T> rather than T[].
2019-04-01 05:28:21 +02:00
Oliver Blanthorn
a2cf6671f2
Merge pull request #1422 from tridactyl/add_tslint_sonarts
Add tslint sonarts
2019-03-31 15:24:31 +01:00
glacambre
d36eedf05b
Add tslint and sonarts to Travis
Tslint and sonarts are pretty cool linters/static analyzers. Currently,
we ask them to ignore any of the rules that Tridactyl might not respect.
This enables progressively re-enabling rules and submitting small,
reviewable PRs that fix things.
2019-03-31 16:08:31 +02:00
glacambre
bcd04a349c
Make compiler tslint/tslint-sonarts ready 2019-03-31 13:30:47 +02:00
Oliver Blanthorn
87adde1604
Merge pull request #1420 from glacambre/fix_make_tutorial
Fix make_tutorial
2019-03-28 11:22:51 +00:00
glacambre
ce0da074a5
Fix make_tutorial
PR#1412 broke tutorial generation by adding a dot at the beginning of
$page. This fixes that.
2019-03-28 06:08:49 +01:00
Oliver Blanthorn
0aaabe1b96
Document rapid hints on readme
Really, I just wanted to poke the buildbot
2019-03-27 13:13:47 +00:00
Oliver Blanthorn
6b560beebe
Bump number of beta users 2019-03-27 13:02:02 +00:00
Oliver Blanthorn
6e5528b26a
Merge pull request #1418 from glacambre/fix_wine_pyinstaller
wine-pyinstaller.sh: Fix checkPrerequisite()
2019-03-27 12:11:20 +00:00
glacambre
fdd278f8f2
wine-pyinstaller.sh: Fix checkPrerequisite()
The problem was the `[ ! -f "${bin_loc}" ]` check. `command -v` does not
necessarily return an absolute path (it can just return the name of the
command for builtins) and this is what happened for 'printf'. Thus, the
`[ ! -f` check failed.
This check doesn't really make sense. If `command -v $binary` doesn't
fail you're good to go, it doesn't really matter where $binary is
located.
2019-03-27 12:47:20 +01:00
Oliver Blanthorn
95259033c6
Merge branch 'add_shellcheck' 2019-03-26 14:49:32 +00:00
Oliver Blanthorn
9956c3b0f5 Document allowautofocus gotchas 2019-03-26 14:14:20 +00:00
Oliver Blanthorn
c1d514e098
Merge pull request #1417 from glacambre/fix_winopen_native
Fix `:winopen -private about:addons` not working
2019-03-26 12:25:59 +00:00
glacambre
b2e88f8a02
Fix :winopen -private about:addons not working 2019-03-26 08:27:38 +01:00
Oliver Blanthorn
1f12c31615
Merge pull request #1414 from glacambre/fix_editor_doc
Fix editor documentation
2019-03-25 13:30:19 +00:00
glacambre
018c247dae
Fix editor documentation
You shouldn't single-quote values you give to editorcmd.

Closes #1413.
2019-03-25 05:21:00 +01:00
glacambre
78e662efef
Add shellcheck to travis 2019-03-24 18:28:41 +01:00
Oliver Blanthorn
8539840eb3
release 1.14.9 2019-03-21 15:22:46 +00:00
Oliver Blanthorn
83b0613be1
Update min version to 65 2019-03-21 15:21:55 +00:00
Oliver Blanthorn
be54db96be
Update changelog for 1.14.9 2019-03-21 15:20:41 +00:00
Oliver Blanthorn
fd9d34bbe2
Start updating changelog for 1.14.9 2019-03-17 16:48:50 +00:00
Colin Caine
618f7f6446 excmds: document composite 2019-03-12 23:45:08 +00:00
Oliver Blanthorn
4d3b86f5ee
Merge branch 'remove_commandline_background' 2019-03-12 15:15:58 +00:00
Oliver Blanthorn
64230c8f3c
Merge pull request #1405 from glacambre/fix_1399
controller_content.ts: Fix typo in variable name
2019-03-09 17:38:33 +00:00
glacambre
03bfb3f825
controller_content.ts: Fix typo in variable name 2019-03-09 18:07:57 +01:00
Oliver Blanthorn
59a2147172
Merge pull request #1404 from max-sixty/patch-1
Fix readme link
2019-03-09 09:28:33 +00:00
Maximilian Roos
efca5e3f66
Fix readme link 2019-03-08 16:49:37 -05:00
Oliver Blanthorn
31e4777296
Merge pull request #1402 from glacambre/fix_windows_nativeopen_escaping
excmds.ts: Fix nativeopen using wrong escaping scheme on windows
2019-03-06 07:58:00 +00:00
glacambre
6a4e2e3c41
excmds.ts: Fix nativeopen using wrong escaping scheme on windows
See comment in patch for explanations.
2019-03-06 06:49:47 +01:00