Commit graph

13651 commits

Author SHA1 Message Date
Kai Fricke
1b06e7a83a
[tune] Only sync down from cloud if needed (#26725)
Currently, trainables will try to sync up/down temporary checkpoints from cloud storage, leading to errors. These erros come up e.g. with PBT, which heavily uses saving/restoring from objects.

Instead, we should not sync these temporary checkpoints up at all, and we should generally not sync down if a local checkpoint directory exists, which will prevent us also from trying to sync down non-existent temporary checkpoint directories.

See #26714

Signed-off-by: Kai Fricke <kai@anyscale.com>
2022-07-25 21:49:01 +01:00
Siyuan (Ryans) Zhuang
4cc1ef1557
[Core] Refactoring Ray DAG object scanner (#26917)
* make sure Ray DAG can work with minimal install

Signed-off-by: Siyuan Zhuang <suquark@gmail.com>\
2022-07-25 13:48:09 -07:00
Kai Fricke
df217d15e0
[air] Raise error on path-like access for Checkpoints (#26970)
Calling e.g. `os.path.exists(checkpoint)` currently raises an TypeError, but we should make it more explicit and guide users towards the correct API.

Signed-off-by: Kai Fricke <kai@anyscale.com>
2022-07-25 21:45:31 +01:00
Jiao
5315f1e643
[AIR] Enable other notebooks previously marked with # REGRESSION (#26896)
Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
2022-07-25 13:40:21 -07:00
kourosh hakhamaneshi
5030a4c1d3
[RLlib] Simplify agent collector (#26803) 2022-07-25 13:17:17 -07:00
matthewdeng
df638b3f0f
[Datasets] Automatically cast tensor columns when building Pandas blocks. (#26924)
This PR just applies the changes from the following PRs:

[Datasets] Automatically cast tensor columns when building Pandas blocks. #26684
reverted by Revert "[Datasets] Automatically cast tensor columns when building Pandas blocks." #26921
[AIR - Datasets] Fix TensorDtype construction from string and fix example. #26904
This fixes the test failures introduced in the originally reverted PRs.
2022-07-25 12:12:10 -07:00
Siyuan (Ryans) Zhuang
0e1b77d52a
[Workflow] Fix flaky example(#26960)
Signed-off-by: Siyuan Zhuang <suquark@gmail.com>
2022-07-25 12:00:45 -07:00
Alan Guo
e8222ff600
[dashboard] Update cluster_activities endpoint to use pydantic. (#26609)
Update cluster_activities endpoint to use pydantic so we have better data validation.

Make timestamp a required field.
Add pydantic to ray[default] requirements
2022-07-25 10:54:22 -07:00
Richard Liaw
aae0aaedbd
[air] Un-revert "[air] remove unnecessary logs + improve repr for result" (#26942) 2022-07-25 10:35:25 -07:00
Jiao
bf1d9971f1
[setup-dev] Add flag to skip symlink certain folders (#26899) 2022-07-25 10:21:20 -07:00
Kai Fricke
ec1995a662
[air/tune/docs] Cont. convert Tune examples to use Tuner.fit() (#26959) 2022-07-25 09:52:12 -07:00
Kai Fricke
de7bd015a4
[air/tune/docs] Change Tuner() occurences in rest of ray/tune (#26961) 2022-07-25 09:47:48 -07:00
matthewdeng
3ea80f6aa1
[data] set iter_batches default batch_size (#26955)
Why are these changes needed?
Resubmitting #26869.

This PR was reverted due to failing tests; however, those failures were actually due to a dependency: #26950
2022-07-25 08:34:25 -07:00
Artur Niederfahrenhorst
b1594260ba
[RLlib] Small SlateQ example fix. (#26948) 2022-07-25 15:12:42 +02:00
Avnish Narayan
41c9ef709a
[RLlib] Using PG when not doing microbatching kills A2C performance. (#26844) 2022-07-25 15:11:26 +02:00
matthewdeng
794a81028b
[ci] add repro-ci-requirements.txt (#26951)
Adding a requirements file to make it easier to setup you environment to run `repro-ci.py`.

**Usage:**
```bash
pip install -r ci/repro-ci-requirements.txt
python ci/repro-ci.py [args]
```

Signed-off-by: Matthew Deng <matt@anyscale.com>
2022-07-25 14:09:48 +01:00
Guyang Song
bf97a6944b
[Dashboard] Actor Table UI Optimize (#26785)
Co-authored-by: 多牧 <xuzhi.mxz@antfin.com>
2022-07-25 18:49:48 +08:00
Tao Wang
4d6cbb0fd4
[Java]More efficient getAllNodeInfo() (#26872)
Like https://github.com/ray-project/ray/pull/26760, we remove the unnecessary rpc calls for each node to get their resources, instead we use the existing fields.
2022-07-25 16:53:03 +08:00
Kai Fricke
abde2a5f97
[tune] Fix current best trial progress string for metric=0 (#26943)
Signed-off-by: Kai Fricke <kai@anyscale.com>
2022-07-25 00:41:26 -07:00
Siyuan (Ryans) Zhuang
4a1ad3e87a
[Workflow] Support "retry_exceptions" of Ray tasks (#26913)
* support 'retry_exceptions'

Signed-off-by: Siyuan Zhuang <suquark@gmail.com>

* add test

Signed-off-by: Siyuan Zhuang <suquark@gmail.com>

* add doc

Signed-off-by: Siyuan Zhuang <suquark@gmail.com>

* fix

Signed-off-by: Siyuan Zhuang <suquark@gmail.com>

* typo

Signed-off-by: Siyuan Zhuang <suquark@gmail.com>
2022-07-24 20:50:11 -07:00
matthewdeng
a012033033
[ci] pin werkzeug (#26950)
Signed-off-by: Matthew Deng matt@anyscale.com

Note: This aims to mitigate the errors of the failing tests, but a follow-up is needed for a long-term solution.

Why are these changes needed?

A bunch of CI tests started failing on 7/23.

Quick sanity check shows only werkzeug was upgraded from 2.1.2 to 2.2.0. The new version was released on 7.23.

Verified that running pip install -U Werkzeug==2.1.2 fixes (at least) test_dataset_formats.
2022-07-24 20:09:09 -07:00
SangBin Cho
15b711ae6a
[State Observability] Warn if callsite is disabled when ray list objects + raise exception on missing output (#26880)
This PR does 3 things.
1. Warn if callsite is disabled when `ray list objects` and `ray summary objects`
2. Decode owner_id for ray list actors
3. Support raise_on_missing_output
2022-07-24 19:55:36 -07:00
Eric Liang
1ac2a872e7
[docs] Editing pass over Dataset docs (#26935) 2022-07-24 19:48:29 -07:00
Richard Liaw
d01a80eb11
[core] runtime context resource ids getter (#26907) 2022-07-24 16:56:44 -07:00
Chen Shen
acbab51d3e
[Nightly] fix microbenchmark scripts (#26947)
Signed-off-by: scv119 scv119@gmail.com

Why are these changes needed?
microbenchmarks failed complaining

   raise ValueError(f"Malformed address: {address}")
ValueError: Malformed address: 
this is due to 55a0f7b and fix it by set RAY_ADDRESS="local"
2022-07-24 14:16:43 -07:00
Yi Cheng
0c16619475
[core] Make ray able to connect to redis without pip redis. (#25875)
Signed-off-by: Yi Cheng <chengyidna@gmail.com>

## Why are these changes needed?
Right now, only cpp layer in ray is connecting to redis which means we don't need pip redis to connect to a redis db.

The blocking part is that we are doing some sharding in redis right now. But this feature is not actually used and the shard is always 1. So to make things simple, this feature is just disabled.

Test is added to make sure we can start ray with a redis db without pip redis.
2022-07-24 14:11:30 -07:00
Kai Fricke
8d7b865614
[air/tuner/docs] Update docs for Tuner() API 2a: Tune examples (non-docs) (#26931)
Splitting up #26884: This PR includes changes to use Tuner() instead of tune.run() for all examples included in python/ray/tune/examples

Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>

Co-authored-by: xwjiang2010 <xwjiang2010@gmail.com>
Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
2022-07-24 21:00:22 +01:00
Kai Fricke
803c094534
[air/tuner/docs] Update docs for Tuner() API 2b: Tune examples (ipynb) (#26884)
This PR updates the Ray AIR/Tune ipynb examples to use the Tuner() API instead of tune.run().

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
Signed-off-by: Xiaowei Jiang <xwjiang2010@gmail.com>
Signed-off-by: Kai Fricke <coding@kaifricke.com>

Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
Co-authored-by: Xiaowei Jiang <xwjiang2010@gmail.com>
2022-07-24 18:53:57 +01:00
Eric Liang
008eecfbff
[docs] Update the AIR data ingest guide (#26909) 2022-07-24 09:59:29 -07:00
Cheng Su
e19cf164fd
[Datasets] Use sampling to estimate in-memory data size for Parquet data source (#26868) 2022-07-24 09:58:57 -07:00
Kai Fricke
8fe439998e
[air/tuner/docs] Update docs for Tuner() API 1: RSTs, docs, move reuse_actors (#26930)
Signed-off-by: Kai Fricke coding@kaifricke.com

Why are these changes needed?
Splitting up #26884: This PR includes changes to use Tuner() instead of tune.run() for most docs files (rst and py), and a change to move reuse_actors to the TuneConfig
2022-07-24 07:45:24 -07:00
Kai Fricke
c01bb831d4
[hotfix/data] Fix linter for test_split (#26944)
Signed-off-by: Kai Fricke <kai@anyscale.com> fix linting
2022-07-24 07:01:36 -07:00
Christy Bergman
e9503dbe2b
[RLlib] Push suggested changes from #25652 docs wording Parametric Models Action Masking. (#26793) 2022-07-24 15:36:55 +02:00
Artur Niederfahrenhorst
e9a8f7d9ae
[RLlib] Unify gnorm mixin for tf and torch policies. (#26102) 2022-07-24 15:31:09 +02:00
Yi Cheng
c44d9ff397
[core] Fix the deadlock in submit task when actor failed. (#26898)
Signed-off-by: Yi Cheng <chengyidna@gmail.com>

## Why are these changes needed?

When actor died, it'll send notification to core workers. Right now, sometimes, core worker will queue the task waiting for actor death info and pop it up for better usability. But in async cases, this is going to cause issues.

The callback might submit tasks which require holding the lock. But it's already being held. This is going to cause a deadlock.

This PR fixed this by moving the failure part out of the lock.
2022-07-24 00:23:49 -07:00
Jian Xiao
90cea203be
Ray 2.0 API deprecation (#26116)
Ray 2.0 API deprecation for:

 ray.remote(): placement_group
 ray.remote(): placement_group_bundle_index
 ray.remote(): placement_group_capture_child_tasks
 ray.get_dashboard_url()
 ray.get_resource_ids()
 ray.disconnect()
 ray.connect()
 ray.util.ActorGroup
 ray.util.ActorPool
 Add get_xx_id() to return hex (rather than object), and then deprecate the xx_id() (which returns Cython object): the xx here can be node, task etc.
 ray start: --plasma-store-socket-name
 ray start: --raylet-socket-name
2022-07-23 22:18:58 -07:00
Chen Shen
aaab4abad5
[Data][Split] stable version of split with hints (#26778)
Why are these changes needed?
Introduce a stable version of split with hints with a stable equalizing algorithm:

use the greedy algorithm to generate the initial unbalanced splits.
for each splits, first shave them so the number for rows are below the target_size
based on how many rows needed for each split, do a one time split_at_index to the left over blocks.
merge the shaved splits with the leftover splits.
The guarantee of this algorithm is we at most need to split O(split) number of blocks.
2022-07-23 22:13:11 -07:00
SangBin Cho
37f4692aa8
[State Observability] Fix "No result for get crashing the formatting" and "Filtering not handled properly when key missing in the datum" #26881
Fix two issues

No result for get crashing the formatting
Filtering not handled properly when key missing in the datum
2022-07-23 21:33:07 -07:00
Eric Liang
d692a55018
[data] Make lazy mode non-experimental (#26934) 2022-07-23 21:28:31 -07:00
Ishant Mrinal
b32c784c7f
[RLLib] RE3 exploration algorithm TF2 framework support (#25221) 2022-07-23 18:05:01 -07:00
matthewdeng
bcec60d898
Revert "[data] set iter_batches default batch_size #26869 " (#26938)
This reverts commit b048c6f659.
2022-07-23 17:46:45 -07:00
Jian Xiao
da9581b746
GC the blocks that have been splitted during .split() if they are owned by consumer (#26902)
Eagerly GC blocks no longer needed to improve memory efficiency and reduce object spilling.
2022-07-23 16:41:22 -07:00
matthewdeng
b048c6f659
[data] set iter_batches default batch_size #26869
Why are these changes needed?
Consumers (e.g. Train) may expect generated batches to be of the same size. Prior to this change, the default behavior would be for each batch to be one block, which may be of different sizes.

Changes
Set default batch_size to 256. This was chosen to be a sensible default for training workloads, which is intentionally different from the existing default batch_size value for Dataset.map_batches.
Update docs for Dataset.iter_batches, Dataset.map_batches, and DatasetPipeline.iter_batches to be consistent.
Updated tests and examples to explicitly pass in batch_size=None as these tests were intentionally testing block iteration, and there are other tests that test explicit batch sizes.
2022-07-23 13:44:53 -07:00
Jiao
3dc4189d88
Revert "[air] remove unnecessary logs + improve repr for result (#26906)" (#26932) 2022-07-23 12:12:26 -07:00
Stephanie Wang
55a0f7bb2d
[core] ray.init defaults to an existing Ray instance if there is one (#26678)
ray.init() will currently start a new Ray instance even if one is already existing, which is very confusing if you are a new user trying to go from local development to a cluster. This PR changes it so that, when no address is specified, we first try to find an existing Ray cluster that was created through `ray start`. If none is found, we will start a new one.

This makes two changes to the ray.init() resolution order:
1. When `ray start` is called, the started cluster address was already written to a file called `/tmp/ray/ray_current_cluster`. For ray.init() and ray.init(address="auto"), we will first check this local file for an existing cluster address. The file is deleted on `ray stop`. If the file is empty, autodetect any running cluster (legacy behavior) if address="auto", or we will start a new local Ray instance if address=None.
2. When ray.init(address="local") is called, we will create a new local Ray instance, even if one is already existing. This behavior seems to be necessary mainly for `ray.client` use cases.

This also surfaces the logs about which Ray instance we are connecting to. Previously these were hidden because we didn't set up the log until after connecting to Ray. So now Ray will log one of the following messages during ray.init:
```
(Connecting to existing Ray cluster at address: <IP>...)
...connection...
(Started a local Ray cluster.| Connected to Ray Cluster.)( View the dashboard at <URL>)
```

Note that this changes the dashboard URL to be printed with `ray.init()` instead of when the dashboard is first started.

Co-authored-by: Eric Liang <ekhliang@gmail.com>
2022-07-23 11:27:22 -07:00
Siyuan (Ryans) Zhuang
1fa8ddb07a
[Workflow] Make sure no side effects during workflow resuming (#26918)
Signed-off-by: Siyuan Zhuang <suquark@gmail.com>
2022-07-23 11:04:07 -07:00
Avnish Narayan
a50a81a13a
Revert "[RLlib] Fix apex breakout release test performance. (#26867)" (#26927) 2022-07-23 17:27:50 +02:00
Rohan Potdar
a53bbe49bf
[RLlib]: Raise deprecation warning in MARWIL OPE methods. (#26893) 2022-07-23 13:55:40 +02:00
Rohan Potdar
97bcf38ec0
[RLlib] Fix torch None conversion in torch_utils.py::convert_to_torch_tensor. (#26863) 2022-07-23 13:54:57 +02:00
Rohan Potdar
69f6b843da
[RLlib] Test output length in DatasetReader with default IOContext. (#26852) 2022-07-23 13:53:59 +02:00