Commit graph

10749 commits

Author SHA1 Message Date
Chen Shen
c9c3f0745a
[Dataset][nighlytest] use latest ray for running test #21148
We are actually using the ray comes with the image, which is on a very old version of Ray. (suprised this actually works)
2021-12-17 23:48:44 -08:00
Jun Gong
c98d4fe2f3
[ci] Change build-wheel-macos-arm64.sh to be executable. (#21164)
So the script can be simply executed. All the other build-wheels-xxx.sh are executable.
2021-12-17 17:23:10 -08:00
architkulkarni
56bd8e58de
[CI] [Release] uninstall Ray before installing new Ray version (#21159) 2021-12-17 16:25:15 -08:00
Clark Zinzow
c3d68fa0c1
[Dask-on-Ray] Add Dask config helper, set task-based shuffle by default. (#21114)
Dask default's to a disk-based shuffle even thought we're using a distributed scheduler, which appears to be resulting in dropped data since the filesystem isn't shared across nodes. Dask Distributed manually sets the shuffle algorithm in the global config to the task-based shuffle, which the Dask-on-Ray scheduler should probably do as well.

This PR adds a Dask config helper, `enable_dask_on_ray`, that sets Dask-on-Ray as the default scheduler along with changing the default shuffle to a task-based shuffle. The shuffle method can still be overridden by the user by manually specifying `df.set_index(shuffle="disk")`.
2021-12-17 13:16:37 -08:00
Chen Shen
d99f699e3d
Revert "[Core][GCS] Use port and address flags to configure GCS server / client in GCS bootstrapping mode (#21115)" (#21157)
This reverts commit 0e7c0b491b.
2021-12-17 11:48:40 -08:00
xwjiang2010
ce81ad21f3
Revert "[tune] Elongate test_trial_scheduler_pbt timeout. (#21120)" (#21155) 2021-12-17 11:32:00 -08:00
Gagandeep Singh
14fc023cb6
Bump timeout value for test_worker_capping.py::test_zero_cpu_scheduling (#21035) 2021-12-17 10:51:54 -08:00
Simon Mo
956774e757
[CI] Disable serve test_standalone on windows again (#21154) 2021-12-17 10:32:27 -08:00
Hankpipi
04ecdee9db
[Serve] Fix serve metrics test (#21140) 2021-12-17 10:23:17 -08:00
shrekris-anyscale
7e15a8199e
[Serve] Reduce test_cluster flakiness by increasing timeout (#21146) 2021-12-17 10:22:56 -08:00
SangBin Cho
02465a6792
Revert "[Placement Group] Make placement group prepare resource rpc r… (#21144)
This PR makes pg_test_2 flaky. cc @clay4444 can you re-merge it?
2021-12-17 00:13:26 -08:00
mwtian
0e7c0b491b
[Core][GCS] Use port and address flags to configure GCS server / client in GCS bootstrapping mode (#21115)
This change adds support for parsing `--address` as bootstrap address, and treating `--port` as GCS port, when using GCS for bootstrapping.

Not launching Redis in GCS bootstrapping mode, and using GCS to fetch initial cluster information, will be implemented in a subsequent change.

Also made some cleanups.
2021-12-16 15:11:05 -08:00
Matti Picus
29965ad325
enable passing serve tests on windows (#21107)
* enable passing serve tests on windows

* move test_handle to 'medium' and enable'

* move test_cli to 'medium'
2021-12-16 14:03:11 -08:00
architkulkarni
4dcba1d0f4
[CI] Pin anyscale version to fix release tests (#21138) 2021-12-16 13:15:16 -08:00
Simon Mo
0f0813b7b6
[Serve] Bump test_cli timeout (#21139) 2021-12-16 11:00:22 -08:00
Hankpipi
97d3142c59
[Serve] Fix naming error and add Serve metric for HTTP error codes (#21009) 2021-12-16 09:48:03 -08:00
Scott Graham
7153d58cbd
Updates to azure autoscaler for authentication and dependency updates (#19603)
* updating azure autoscaler versions and backwards compatibility, and moving to azure-identity based authentication

* adding azure sdk rqmts for tests

* updating azure test requirements and adding wrapper function for azure sdk function resolution

* adding docstring to get_azure_sdk_function

Co-authored-by: Scott Graham <scgraham@microsoft.com>
2021-12-16 09:23:32 -08:00
xwjiang2010
a85df8c528
[tune] Elongate test_trial_scheduler_pbt timeout. (#21120) 2021-12-16 17:19:57 +01:00
Tomasz Wrona
5836cf9b1c
[Tune] Allow for tuples in _split_resolved_unresolved_values. (#20794) 2021-12-16 10:20:54 +01:00
Avnish Narayan
85a368c720
[RLlib] Expand Base env API to add necessary methods for testing. (#21027) 2021-12-16 10:19:49 +01:00
Guyang Song
32cf19a881
[runtime env] add and remove uri reference in worker pool (#20789)
Currently, the logic of uri reference in raylet is:
- For job level, add uri reference when job started and remove uri reference when job finished.
- For actor level, add and remove uri reference for detached actor only.

In this PR, the logic is optimized to:
- For job level, check if runtime env should be installed eagerly first. If true, add or remove uri reference. 
- For actor level
    * First, add uri reference for starting worker process to avoid that runtime env is gcd before worker registered.
    * Second, add uri reference for echo worker thread of worker process. We will remove reference when worker disconnected.

- Besides, we move the instance of `RuntimeEnvManager` from `node_manager` to `worker_pool`.
- Enable the test `test_actor_level_gc` and add some tests in python and worker pool test.
2021-12-16 01:00:05 -08:00
Yi Cheng
a778741db6
[gcs] Update constructor of gcs client (#21025)
GcsClient accepts only redis before. To make it work without redis, we need to be able to pass gcs address to gcs client as well.

In this PR, we add GCS related into into GcsClientOptions so that we can connect to the gcs directly with gcs address.

This  PR is part of GCS bootstrap. In the following PR, we'll add functionality to set the correct GcsClientOptions based on flags.
2021-12-16 00:19:37 -08:00
brulu
8b77fc0aef
[RLlib] Updating Repeated space. Allowing numpy arrays and adding representation. (#20799) 2021-12-16 08:27:55 +01:00
DK.Pino
1edf4ab041
[Placement Group] Make placement group prepare resource rpc request batched (#20897)
This is one part of this refactor,  #20715 , make the prepare resource RPC requests batched per node.
2021-12-15 22:32:50 -08:00
Eric Liang
19390705e1
[data] Shuffle stats for datasets (#21070)
This PR fills in the shuffle stats TODOs, as well as adding some common stats measurement machinery.
2021-12-15 21:56:10 -08:00
Chen Shen
80eb00f525
[Chaos] fix dataset chaos test #21113 2021-12-15 20:13:38 -08:00
Simon Mo
e453bfdb8e
[Serve] Run long poll callbacks in event loop (#21104) 2021-12-15 16:27:08 -08:00
Yi Cheng
abdf9b5f3c
[nightly] Fix benchmark commit check failure (#21119)
It looks like somehow `pip3 install -U` won't update ray anymore, and we need to uninstall before installing.
2021-12-15 14:54:03 -08:00
Matti Picus
d2cd0730a0
[Windows] Enable test_advanced_2 on windows (#20994) 2021-12-15 14:30:40 -08:00
Sven Mika
e485aa846a
[RLlib; Docs overhaul] Overhaul of auto-API reference pages (via sphinx autoclass/automodule). (#19786) 2021-12-15 22:32:52 +01:00
Ian Rodney
c7fb5a94d1
[CI] Upgrade Pip to 21.3 (#21111) 2021-12-15 13:29:45 -08:00
Clark Zinzow
ec06a1f65e
[CUJ#2] Update nightly test for CUJ#2 #21064 2021-12-15 13:19:59 -08:00
Chen Shen
03e05df9cb
[Core] fix wrong memory size reporting #21089
The current resource reporting is run in OSS. Revert the change. For example it reported

InitialConfigResources: {node:172.31.45.118: 1.000000}, {object_store_memory: 468605759.960938 GiB},
For 10GB memory object_store.
2021-12-15 10:24:35 -08:00
xwjiang2010
33b6cd9105
[tune] _cached_actor_pg can only be non empty when reuse_actors = True. (#21067)
Removes dead code path.
2021-12-15 18:59:29 +01:00
SangBin Cho
2878161a28
[Core] Properly implement some blocking RPCs with promise. Actor + KV store (#20849)
This PR implements gRPC timeout for various blocking RPCs.

Previously, the timeout with promise didn't work properly because the client didn't cancel the timed out RPCs. This PR will properly implement RPC timeout.

This PR supports;

- Blocking RPCs for core APIs, creating / getting / removing actor + pg.
- Internal KV ops

The global state accessor also has the infinite blocking calls which we need to fix. But fixing them requires a huge refactoring, so this will be done in a separate PR. 

Same for the placement group calls (they will be done in a separate PR)

Also, this means we can have scenario such as the client receives the DEADLINE EXCEEDED error, but the handler is invoked. Right now, this is not handled correctly in Ray. We should start thinking about how to handle these scenarios better.
2021-12-15 06:46:43 -08:00
simonsays1980
1a8aa2da1f
[RLlib] Added `tensorlib=numpy' to 'restore_original_dimensions()' such that … (#20342) 2021-12-15 14:03:18 +01:00
Alexis DUBURCQ
6c3e63bc9c
[RLlib] Fix view requirements. (#21043) 2021-12-15 11:59:04 +01:00
Jun Gong
767f78eaf8
[RLlib] Always attach latest eval metrics. (#21011) 2021-12-15 11:42:53 +01:00
SangBin Cho
1c1430ff5c
Add memory monitor to scalability tests. (#21102)
This adds memory monitoring to scalability envelope tests so that we can compare the peak memory usage for both nonHA & HA.

NOTE: the current way of adding memory monitor is not great, and we should implement fixture to support this better, but that's not in progress yet.
2021-12-15 01:31:38 -08:00
Kai Fricke
ecbf29ec03
[tune] Fix best_trial_str for nested custom parameter columns (#21078)
Currently, custom nested parameter_columns are not printed correctly in the best trial string. This PR fixes the printing error and adds a unit test.
2021-12-15 10:26:22 +01:00
Ian Rodney
deb3505150
[Java] Bump Log4j2 to completely remove lookups (#21081)
As per the 2.16.0 release of Lo4j2, Lookup support is removed 🎉 
https://logging.apache.org/log4j/2.x/changes-report.html#a2.16.0
2021-12-15 15:45:56 +08:00
WanXing Wang
1c3506a2aa
[Streaming]Fix potential memory problems when delete buffer. (#21101)
`delete buffer` -> `delete[] buffer` to fix potential memory problems under C++14, such as jemalloc deadlock.
2021-12-15 15:24:23 +08:00
Jiao
e9daacff60
[Job][Docs] Update docs architecture image link (#21087) 2021-12-14 23:07:38 -08:00
Jiao
ed34434131
[Jobs] Add log streaming for jobs (#20976)
Current logs API simply returns a str to unblock development and integration. We should add proper log streaming for better UX and external job manager integration.

Co-authored-by: Sven Mika <sven@anyscale.io>
Co-authored-by: sven1977 <svenmika1977@gmail.com>
Co-authored-by: Ed Oakes <ed.nmi.oakes@gmail.com>
Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
Co-authored-by: Simon Mo <simon.mo@hey.com>
Co-authored-by: Avnish Narayan <38871737+avnishn@users.noreply.github.com>
Co-authored-by: Jiao Dong <jiaodong@anyscale.com>
2021-12-14 17:01:53 -08:00
Edward Oakes
10947c83b3
[runtime_env] Make pip installs incremental (#20341)
Uses a direct `pip install` instead of creating a conda env to make pip installs incremental to the cluster environment.

Separates the handling of `pip` and `conda` dependencies.

The new `pip` approach still works if only the base Ray is installed on the cluster and the user specifies libraries like "ray[serve]" in the `pip` field.  The mechanism is as follows:
- We don't actually want to reinstall ray via pip, since this could lead to version mismatch issues.  Instead, we want to use the Ray that's already installed in the cluster.
- So if "ray" was included by the user in the pip list, remove it
- If a library "ray[serve]" or "ray[tune, rllib]" was included in the pip list, remove it and replace it by its dependencies (e.g. "uvicorn", "requests", ..)

Co-authored-by: architkulkarni <arkulkar@gmail.com>
Co-authored-by: architkulkarni <architkulkarni@users.noreply.github.com>
2021-12-14 15:55:18 -08:00
Gagandeep Singh
57cc76cf5e
[windows][ci] Increase in num_tasks for stable wait times in test_worker_capping:test_exponential_wait (#21051)
The `results` with lesser tasks contains un-stable wait times, so increased the number of tasks in a hope for less noisy wait times. Minor in changes in assert comparisons have also been made for lesser error.
2021-12-14 15:54:55 -08:00
newmanwang
42a108ff60
[gcs] Fix can not resue actor name in same namespace (#21053)
Before this PR, GcsActorManager::CreateActor() would replace actor's namespace by
actors's owner job's namespace, even if actor is created by user with a user specified
namespace. But in named_actors_, actor is set to use user specified namespace by
GcsActorManager::RegisterActor before CreateActor() is called, So that
GcsActorManager::DestroyActor failed to find actor from named_actors_ by owner job's
namespace to remove, hence reuse actor name in same namespace failed for same name actor
not removed by GcsActorManager::DestroyActor in named_actors_.

issue #20611
2021-12-14 14:20:49 -08:00
SangBin Cho
5665b69fff
[Internal Observability] Record GCS debug stats to metrics (#20993)
Streamline all existing GCS debug state to metrics.
2021-12-14 14:19:37 -08:00
Junwen Yao
8325a32d66
[Train] Update saving / loading checkpoint documentation (#20973)
This PR updates saving / loading checkpoint examples.

Co-authored-by: matthewdeng <matthew.j.deng@gmail.com>
2021-12-14 09:53:17 -08:00
Matti Picus
aec04989fc
WINDOWS: enable test_advanced_3.py (#21056) 2021-12-14 09:25:23 -08:00