hiro/ray
1
0
Fork 0
mirror of https://github.com/vale981/ray synced 2025-03-06 02:21:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove the RAY_CHECK in Worker::Port() (#9348)

Browse source
This commit is contained in:
Kai Yang 2020-07-10 18:06:25 +08:00 • committed by GitHub
parent a98cd0670e
commit c89b59cf48
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/ray/raylet/worker.cc
View file

@ -65,7 +65,12 @@ Language Worker::GetLanguage() const { return language_; }
const std::string Worker::IpAddress() const { return ip_address_; }
int Worker::Port() const {
RAY_CHECK(port_ > 0);
// NOTE(kfstorm): Since `RayletClient::AnnounceWorkerPort` is an asynchronous
// operation, the worker may crash before the `AnnounceWorkerPort` request is received
// by raylet. In this case, Accessing `Worker::Port` in
// `NodeManager::ProcessDisconnectClientMessage` will fail the check. So disable the
// check here.
// RAY_CHECK(port_ > 0);
return port_;
}