From c89b59cf48592d04b536fe95e8067506a344ea88 Mon Sep 17 00:00:00 2001 From: Kai Yang Date: Fri, 10 Jul 2020 18:06:25 +0800 Subject: [PATCH] Remove the RAY_CHECK in Worker::Port() (#9348) --- src/ray/raylet/worker.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/ray/raylet/worker.cc b/src/ray/raylet/worker.cc index bbde48cb1..432d2ce80 100644 --- a/src/ray/raylet/worker.cc +++ b/src/ray/raylet/worker.cc @@ -65,7 +65,12 @@ Language Worker::GetLanguage() const { return language_; } const std::string Worker::IpAddress() const { return ip_address_; } int Worker::Port() const { - RAY_CHECK(port_ > 0); + // NOTE(kfstorm): Since `RayletClient::AnnounceWorkerPort` is an asynchronous + // operation, the worker may crash before the `AnnounceWorkerPort` request is received + // by raylet. In this case, Accessing `Worker::Port` in + // `NodeManager::ProcessDisconnectClientMessage` will fail the check. So disable the + // check here. + // RAY_CHECK(port_ > 0); return port_; }