We can't use `apollo-server-env` as a project reference because that requires `composite: true`, and that implies `declaration: true`, which doesn't work for `apollo-server-env` because we need to write our own declaration files for re-exported imports.
This commit also removes `apollo-engine-reporting-protobuf` as a reference, which errored out because it doesn't actually contain any TypeScript code.
This PR contains the following updates:
| Package | Type | Update | Change | References |
|---|---|---|---|---|
| codecov | devDependencies | pin | `^3.1.0` -> `3.1.0` | [source](https://renovatebot.com/gh/codecov/codecov-node) |
| jest-junit | devDependencies | pin | `^5.1.0` -> `5.1.0` | [source](https://renovatebot.com/gh/jest-community/jest-junit) |
📌 **Important**: Renovate will wait until you have merged this Pin PR before creating any *upgrade* PRs for the affected packages. Add the preset `:preserveSemverRanges` your config if you instead don't wish to pin dependencies.
---
### Renovate configuration
📅 **Schedule**: PR created on schedule "after 6pm every weekday,before 8am every weekday" in timezone America/Los_Angeles
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻️ **Rebasing**: Whenever PR is stale, or if you modify the PR title to begin with "`rebase!`".
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://renovatebot.com/gh/renovatebot/config-help/issues) if that's undesired.
---
This PR has been generated by [Renovate Bot](https://renovatebot.com/gh/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#apollographql/apollo-server).
This should hopefully make it easier to quickly identify failing tests
within the CircleCI interface since CircleCI will be able to
programmatically consume the test results.
Hopefully this will act as reminder for the future. I've used `NODE` here
as a sort of `TODO` so other references in the codebase might be more easily
located.
Not only did removing this configuration reveal invalid JavaScript code, it
also fixes the source mapping for the coverage reports so that they report
the coverage details based on the original file rather than the `tsc`
compiled output (JavaScript).
Ref: c9375c405b (invalid top-level `return`)
Some changes are easier to mentally consume before they've been prettier'd.
While I'll certainly allow Prettier to do what it wants to do, I've confined
it's changes to this commit for easier reviewability.
Note to the reviewer: this commit is exactly the result of running the
`npm run lint-fix` command on a clean Git working tree.
Ref: c9375c405b
The techniques previously used to skip particular tests for particular
Node.js versions (for example, file uploads, Hapi, etc.) were problematic in
a couple ways:
1. `return`-ing outside a function (say, at the top level of a module) is
not valid ECMAScript. While it works in this current state, it only works
because of Babel's wrapping scope. As we move toward less and less
transpiled modules, this would become problematic anyway, but it's a
short-term blocker for me since I intend on dropping the `skipBabel` option
we currently pass to` `ts-jest` in its current (`package.json`)
configuration. (My editor also dislikes top-level `return`, expectedly.)
2. By `return`-ing from a test which we wish to skip conditionally, we avoid
the awareness which is provided by Jest (automatically) when using its
built-in `.skip` helpers. By switching to technique I've employed here,
we're able to see `<num> skipped` in Jest's output and (rightfully) be able
to question why something is being skipped.
By using the `atLeastMajorNodeVersion` helper, we'll also be able to more
easily find where this pattern is used in test-cases, to more easily
re-evaluate their use-cases when we add support newer Node.js versions.
This adds the `--coverage` flag to the `test:ci` (Jest) script, in addition to
adding two new commands (mirroring the pattern used in Apollo Client's
repository): `npm run coverage` and `npm run coverage:upload`.
CircleCI has been configured with the appropriate `CODECOV_TOKEN`.
Rather than using platform-specific `find` and `rm`, we can leverage `git
clean` which will also work on Windows (in addition to making this command
more succinct).
This also runs in a fraction of the time than the `find` + `rm` approach.
This allows us to DRY up the `package.json` file and allows editors which
understand Prettier support to be aware of exactly which files are meant to
be covered, rather than including it within the CLI flags.
This is closer to removing `npm run testonly` which seems less intuitive
than it could be since, grammatically speaking, the `npm test` command
implies that it's only doing testing, not also recompilation.
Testing environments should already be configured to run `npm install`
followed by `npm test` (or the shorthands: `npm install-test` and `npm it`)
Therefore, if someone _wants_ the full recompilation running `npm it` again
will replicate the behavior previously accomplished by `npm test`. I find
this more intuitive since the `npm install` step was already doing the
complication (and necessary to produce a functioning Apollo Server monorepo).
And similarly, `npm test` now just runs the tests, rather than the more
expensive recompilation. This should become even more useful when we move
to a pattern where `tsc` incremental building is implemented.
Since we’ve moved to independent versioning the statement about every package within this repository being at the same version is no longer true. While we’ll need to improve our `CHANGELOG.md` story a bit to account for this, it’s best that we remove this statement to avoid confusing library consumers.
This PR contains the following updates:
| Package | Type | Update | Change | References |
|---|---|---|---|---|
| koa | devDependencies | pin | `^2.5.3` -> `2.5.3` | [source](https://renovatebot.com/gh/koajs/koa) |
📌 **Important**: Renovate will wait until you have merged this Pin PR before creating any *upgrade* PRs for the affected packages. Add the preset `:preserveSemverRanges` your config if you instead don't wish to pin dependencies.
---
### Renovate configuration
📅 **Schedule**: PR created on schedule "after 6pm every weekday,before 8am every weekday" in timezone America/Los_Angeles
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻️ **Rebasing**: Renovate will keep this PR updated whenever it falls behind the base branch.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://renovatebot.com/gh/renovatebot/config-help/issues) if that's undesired.
---
This PR has been generated by [Renovate Bot](https://renovatebot.com/gh/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#apollographql/apollo-server).
