Commit graph

27 commits

Author SHA1 Message Date
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
fc8af1c9da owner -> member; set allow/deny for posts, comments, users 2015-04-28 17:15:53 +09:00
Sacha Greif
40d38d1364 clean up comment edit form; continue namespacing users.telescope 2015-04-28 15:54:19 +09:00
Sacha Greif
10166402ef use fields method to restrict fields after all 2015-04-28 11:32:53 +09:00
Sacha Greif
4685c32fc1 using Users.can.editField for post and comment submit and edit methods 2015-04-28 10:45:00 +09:00
Sacha Greif
3f66f1f10c fix voting code 2015-04-28 10:12:35 +09:00
Sacha Greif
e26fb593ea Using AutoForm for comment submit form 2015-04-28 09:44:43 +09:00
Sacha Greif
06106ed124 use schema transforms and editableBy property to control AutoForm omitted fields 2015-04-27 17:15:16 +09:00
Sacha Greif
e0b9bf36b7 namespacing user roles 2015-04-27 17:14:07 +09:00
Sacha Greif
47b7482420 namespace schemas; migrate user profiles 2015-04-27 09:55:29 +09:00
Sacha Greif
2a46bb11e9 rename publication options 2015-04-25 13:20:51 +09:00
Sacha Greif
6a5eee0dcb working on user schema; i18n'ing schemas 2015-04-25 13:03:04 +09:00
Sacha Greif
6fc6ad2b3d stuff 2015-04-25 12:40:23 +09:00
Sacha Greif
36e2d063ce nicer API namespacing 2015-04-24 09:48:36 +09:00
Sacha Greif
8e5446cc75 refactoring custom fields 2015-04-24 09:28:50 +09:00
Sacha Greif
eb0aba65e5 simplifying modules code 2015-04-24 08:13:41 +09:00
Sacha Greif
ab77526a0f namespacing and refactoring template modules 2015-04-23 17:45:37 +09:00
Sacha Greif
478e7ce934 more callback namespacing and refactoring 2015-04-23 16:53:20 +09:00
Sacha Greif
04061aca9e change callback syntax and add return statement 2015-04-23 11:24:59 +09:00
Sacha Greif
f2f8f4b2c3 namespacing voting and scoring 2015-04-23 11:11:07 +09:00
Sacha Greif
c1074a2e5b might work better if I include comment routes… 2015-04-23 10:39:37 +09:00
Sacha Greif
799ea244aa getting core packages to work with api.imply 2015-04-22 16:26:01 +09:00
Sacha Greif
e5f1db1208 remove all packages; temporarily disable sitemap package 2015-04-22 12:46:06 +09:00
Sacha Greif
03f450e9d2 move posts and comments templates to their respective packages 2015-04-22 12:09:57 +09:00
Sacha Greif
99988b6405 add telescope:core 2015-04-22 08:47:23 +09:00
Sacha Greif
a2e9379577 Namespacing router controllers; starting to packageify publications 2015-04-22 08:13:43 +09:00
Sacha Greif
50da57e059 creating comments package 2015-04-22 07:50:26 +09:00