Commit graph

2458 commits

Author SHA1 Message Date
Sacha Greif
c266c91a17 refactor template-level subs pattern 2015-05-02 16:59:20 +09:00
Sacha Greif
19cf05b77f fix daily view 2015-05-02 14:06:22 +09:00
Sacha Greif
1af39159e8 make posts list controller autorun depend on both router and template terms 2015-05-02 13:44:41 +09:00
Sacha Greif
4c7610f102 use _ for consistency 2015-05-02 11:46:36 +09:00
Sacha Greif
80750f83ac UI.registerHelper -> Template.registerHelper; fix logo 2015-05-02 11:45:25 +09:00
Sacha Greif
7b46b5ffb7 Merge branch 'namespace2' of https://github.com/TelescopeJS/Telescope into namespace2
# Conflicts:
#	packages/telescope-posts/lib/routes.js
2015-05-02 09:53:40 +09:00
Sacha Greif
40fe20aac1 working on posts lists templates and subscriptions 2015-05-02 09:52:39 +09:00
Sacha Greif
2be716d79f Merge pull request #934 from mquandalle/jshint
Improve jsHint consistency
2015-05-02 09:47:44 +09:00
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
44d3768d62 working on template level controllers 2015-04-29 14:38:14 +09:00
Sacha Greif
6d7451fa87 various fixes; started working on template-level sub controller 2015-04-29 12:16:14 +09:00
Sacha Greif
7aa7a6f544 generate list of fields from modifier, not from fieldNames 2015-04-28 17:29:28 +09:00
Sacha Greif
fc8af1c9da owner -> member; set allow/deny for posts, comments, users 2015-04-28 17:15:53 +09:00
Sacha Greif
40d38d1364 clean up comment edit form; continue namespacing users.telescope 2015-04-28 15:54:19 +09:00
Sacha Greif
10166402ef use fields method to restrict fields after all 2015-04-28 11:32:53 +09:00
Sacha Greif
4685c32fc1 using Users.can.editField for post and comment submit and edit methods 2015-04-28 10:45:00 +09:00
Sacha Greif
3f66f1f10c fix voting code 2015-04-28 10:12:35 +09:00
Sacha Greif
e26fb593ea Using AutoForm for comment submit form 2015-04-28 09:44:43 +09:00
Sacha Greif
06106ed124 use schema transforms and editableBy property to control AutoForm omitted fields 2015-04-27 17:15:16 +09:00
Sacha Greif
e0b9bf36b7 namespacing user roles 2015-04-27 17:14:07 +09:00
Sacha Greif
78163f1819 namespacing viewParameters 2015-04-27 10:35:06 +09:00
Sacha Greif
f39e6b8626 added API for removing collection fields 2015-04-27 10:30:47 +09:00
Sacha Greif
0a328034ff add API for removing menu items 2015-04-27 10:16:41 +09:00
Sacha Greif
1f87ae90fc give names to callback functions 2015-04-27 10:12:48 +09:00
Sacha Greif
01ddf50c3e adding APIs for removing callbacks and modules 2015-04-27 10:10:52 +09:00
Sacha Greif
47b7482420 namespace schemas; migrate user profiles 2015-04-27 09:55:29 +09:00
Sacha Greif
20020e7d89 small tweaks 2015-04-25 13:49:49 +09:00
Sacha Greif
2a46bb11e9 rename publication options 2015-04-25 13:20:51 +09:00
Sacha Greif
0643437c67 Settings.addToSchema -> Settings.registerField 2015-04-25 13:11:28 +09:00
Sacha Greif
b6e213abc4 Settings.collection -> Settings 2015-04-25 13:04:10 +09:00
Sacha Greif
6a5eee0dcb working on user schema; i18n'ing schemas 2015-04-25 13:03:04 +09:00
Sacha Greif
6fc6ad2b3d stuff 2015-04-25 12:40:23 +09:00
Sacha Greif
d0c97e7ba9 manually merging in changes from user accounts branch 2015-04-25 12:39:07 +09:00
Sacha Greif
1231c2f53f small fixes 2015-04-24 16:34:05 +09:00
Sacha Greif
964f91aa88 refactoring menus API 2015-04-24 10:49:24 +09:00
Sacha Greif
82b186d62a cleaning up subscriptions preloading API 2015-04-24 10:28:11 +09:00
Sacha Greif
7770c21d3a Making module system more flexible to accept wrapping divs 2015-04-24 10:22:17 +09:00
Sacha Greif
36e2d063ce nicer API namespacing 2015-04-24 09:48:36 +09:00
Sacha Greif
8e5446cc75 refactoring custom fields 2015-04-24 09:28:50 +09:00
Sacha Greif
eb0aba65e5 simplifying modules code 2015-04-24 08:13:41 +09:00
Sacha Greif
427fdac70a remove console.log 2015-04-23 17:47:05 +09:00
Sacha Greif
ab77526a0f namespacing and refactoring template modules 2015-04-23 17:45:37 +09:00
Sacha Greif
478e7ce934 more callback namespacing and refactoring 2015-04-23 16:53:20 +09:00
Sacha Greif
bd290058d7 completely refactoring callback hooks system 2015-04-23 15:42:05 +09:00
Sacha Greif
04061aca9e change callback syntax and add return statement 2015-04-23 11:24:59 +09:00
Sacha Greif
f2f8f4b2c3 namespacing voting and scoring 2015-04-23 11:11:07 +09:00
Sacha Greif
d675b21e27 more namespacing 2015-04-23 10:39:58 +09:00
Sacha Greif
c1074a2e5b might work better if I include comment routes… 2015-04-23 10:39:37 +09:00
Sacha Greif
2bf08e59ac add CSS reset package 2015-04-23 09:14:51 +09:00
Sacha Greif
4d9fdf55de Handle case where Pages collection isn't loaded yet (although that should never happen…) 2015-04-23 09:12:04 +09:00