hiro/yabar
1
0
Fork 0
mirror of https://github.com/vale981/yabar synced 2025-03-06 01:51:41 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

xcb_ewmh_get_wm_name_reply frees the reply on return leading a double free if it's again wiped

Browse source
This commit is contained in:
Andrei Barbu 2016-06-04 16:52:56 -04:00
parent c7881b2a34
commit 5d6b388a49
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/ya_draw.c
View file

@ -409,13 +409,15 @@ inline void ya_get_cur_window_title(ya_block_t * blk) {
xcb_get_property_cookie_t wm_ck, wmvis_ck; xcb_get_property_cookie_t wm_ck, wmvis_ck;
wm_ck = xcb_ewmh_get_wm_name(ya.ewmh, ya.curwin); wm_ck = xcb_ewmh_get_wm_name(ya.ewmh, ya.curwin);
wmvis_ck = xcb_ewmh_get_wm_visible_name(ya.ewmh, ya.curwin); wmvis_ck = xcb_ewmh_get_wm_visible_name(ya.ewmh, ya.curwin);
if (xcb_ewmh_get_wm_name_reply(ya.ewmh, wm_ck, &reply, NULL) == 1 || xcb_ewmh_get_wm_visible_name_reply(ya.ewmh, wmvis_ck, &reply, NULL) == 1) { if (xcb_ewmh_get_wm_name_reply(ya.ewmh, wm_ck, &reply, NULL) == 1) {
if (xcb_ewmh_get_wm_visible_name_reply(ya.ewmh, wmvis_ck, &reply, NULL) == 1) {
int len = GET_MIN(blk->bufsize, reply.strings_len); int len = GET_MIN(blk->bufsize, reply.strings_len);
strncpy(blk->buf, reply.strings, len); strncpy(blk->buf, reply.strings, len);
blk->buf[len]='\0'; blk->buf[len]='\0';
} }
xcb_ewmh_get_utf8_strings_reply_wipe(&reply); xcb_ewmh_get_utf8_strings_reply_wipe(&reply);
} }
}
} }
#endif //YA_INTERNAL_EWMH #endif //YA_INTERNAL_EWMH