hiro/tridactyl
1
0
Fork 0
mirror of https://github.com/vale981/tridactyl synced 2025-03-05 17:41:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #4188 from GHolk/master

Browse source 
Fix #4158: bookmarklet execution bug
This commit is contained in:
Oliver Blanthorn 2022-04-25 11:39:31 +02:00 • committed by GitHub
commit bcad918899
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/excmds.ts
View file

@ -1326,14 +1326,8 @@ export async function open(...urlarr: string[]) {
// Open URLs that firefox won't let us by running `firefox <URL>` on the command line // Open URLs that firefox won't let us by running `firefox <URL>` on the command line
return nativeopen(url) return nativeopen(url)
} else if (/^javascript:/.exec(url)) { } else if (/^javascript:/.exec(url)) {
const bookmarklet = url.replace(/^javascript:/, "") const escapeUrl = url.replace(/[\\"]/g, "\\$&")
document.body.append( window.eval(`window.location.href = "${escapeUrl}"`)
html`
<script>
${bookmarklet}
</script>
`,
)
} else { } else {
const tab = await ownTab() const tab = await ownTab()
return openInTab(tab, {}, urlarr) return openInTab(tab, {}, urlarr)