hiro/tridactyl
1
0
Fork 0
mirror of https://github.com/vale981/tridactyl synced 2025-03-05 09:31:41 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

TSLint: re-enable no-self-assignment rule

Browse source
This commit is contained in:
glacambre 2019-04-03 18:34:19 +02:00
parent 0734798c45
commit 600a324941
No known key found for this signature in database
GPG key ID: B9625DB1767553AC
3 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/excmds.ts
View file

@ -1858,7 +1858,7 @@ export async function tabprev(increment = 1) {
// return tabIndexSetActive((await activeTab()).index - increment + 1) // return tabIndexSetActive((await activeTab()).index - increment + 1)
// Kludge until https://bugzilla.mozilla.org/show_bug.cgi?id=1504775 is fixed: // Kludge until https://bugzilla.mozilla.org/show_bug.cgi?id=1504775 is fixed:
return browser.tabs.query({ currentWindow: true, hidden: false }).then(tabs => { return browser.tabs.query({ currentWindow: true, hidden: false }).then(tabs => {
tabs = tabs.sort((t1, t2) => t1.index - t2.index) tabs.sort((t1, t2) => t1.index - t2.index)
let prevTab = (tabs.findIndex(t => t.active) - increment + tabs.length) % tabs.length let prevTab = (tabs.findIndex(t => t.active) - increment + tabs.length) % tabs.length
return browser.tabs.update(tabs[prevTab].id, { active: true }) return browser.tabs.update(tabs[prevTab].id, { active: true })
}) })

2
src/help.ts
View file

@ -117,6 +117,7 @@ async function onExcmdPageLoad() {
) )
// setCommandSetting() can change the height of nodes in the page so we need to scroll to the right place again // setCommandSetting() can change the height of nodes in the page so we need to scroll to the right place again
if (document.location.hash) { if (document.location.hash) {
/* tslint:disable:no-self-assignment */
document.location.hash = document.location.hash document.location.hash = document.location.hash
} }
} }
@ -181,6 +182,7 @@ function addSettingInputs() {
), ),
).then(_ => { ).then(_ => {
if (document.location.hash) { if (document.location.hash) {
/* tslint:disable:no-self-assignment */
document.location.hash = document.location.hash document.location.hash = document.location.hash
} }
}) })

1
tslint.json
View file

@ -23,7 +23,6 @@
"no-eval": false, "no-eval": false,
"no-extra-semicolon": false, "no-extra-semicolon": false,
"no-identical-functions": false, "no-identical-functions": false,
"no-self-assignment": false,
"no-shadowed-variable": false, "no-shadowed-variable": false,
"no-string-literal": false, "no-string-literal": false,
"no-string-throw": false, "no-string-throw": false,