hiro/tridactyl
1
0
Fork 0
mirror of https://github.com/vale981/tridactyl synced 2025-03-06 01:51:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

excmds.ts: Fix taball moving to tab in wrong window

Browse source 
This commit fixes a bug reported by cmcaine. The issue was that when you
have multiple windows on multiple workspaces, taball wouldn't switch
focus to the right tab. This happened because taball relied on
browser.windows.update(id, {focused: true}) having switched to the right
window before calling idFromIndex. This didn't always work because
sometimes window managers will keep the current window focused.
This commit is contained in:
glacambre 2019-05-27 10:08:23 +02:00
parent 787f519494
commit 486958f7fc
No known key found for this signature in database
GPG key ID: B9625DB1767553AC
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/excmds.ts
View file

@ -2880,9 +2880,12 @@ export async function taball(id: string) {
id = windows.indexOf(tab.windowId) + "." + (tab.index + 1)
logger.info(`taball: Bad tab id: ${prevId}, defaulting to ${id}`)
}
const [winindex, tabindex] = id.split(".")
await browser.windows.update(windows[parseInt(winindex, 10) - 1], { focused: true })
return browser.tabs.update(await idFromIndex(tabindex), { active: true })
const [winindex, tabindex_string] = id.split(".")
const winid = windows[parseInt(winindex, 10) - 1]
const tabindex_number = parseInt(tabindex_string, 10) - 1
const tabid = (await browser.tabs.query({ windowId: winid, index: tabindex_number }))[0].id
await browser.windows.update(winid, { focused: true })
return browser.tabs.update(tabid, { active: true })
}
// }}}