hiro/tridactyl
1
0
Fork 0
mirror of https://github.com/vale981/tridactyl synced 2025-03-05 17:41:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

excmds.ts: Fix jumplist breaking help

Browse source 
Before this patch, navigating to a new page made Tridactyl scroll to its
very top. This broke jumping to the definition of a command using `:help
commandname`.
This commit is contained in:
glacambre 2018-06-03 10:06:51 +02:00
parent a9bb149bfa
commit 06215846fe
No known key found for this signature in database
GPG key ID: B9625DB1767553AC
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/excmds.ts
View file

@ -531,6 +531,10 @@ export function loggingsetlevel(logModule: string, level: string) {
//#content_helper
export let JUMPED: boolean
/** This is used as an ID for the current page in the jumplist.
* It has a potentially confusing behavior: if you visit site A, then site B, then visit site A again, the jumplist that was created for your first visit on A will be re-used for your second visit.
* An ideal solution would be to have a counter that is incremented every time a new page is visited within the tab and use that as the return value for getJumpPageId but this doesn't seem to be trivial to implement.
*/
//#content_helper
export function getJumpPageId() {
return document.location.href
@ -546,12 +550,14 @@ export async function curJumps() {
let tabid = await activeTabId()
let jumps = await browserBg.sessions.getTabValue(tabid, "jumps")
if (!jumps) jumps = {}
// This makes sure that `key` exists in `obj`, setting it to `def` if it doesn't
let ensure = (obj, key, def) => {
if (obj[key] === null || obj[key] === undefined) obj[key] = def
}
let page = getJumpPageId()
ensure(jumps, page, {})
ensure(jumps[page], "list", [{ x: 0, y: 0 }])
let dummy = new UIEvent("scroll")
ensure(jumps[page], "list", [{ x: dummy.pageX, y: dummy.pageY }])
ensure(jumps[page], "cur", 0)
saveJumps(jumps)
return jumps