hiro/tdesktop
1
0
Fork 0
mirror of https://github.com/vale981/tdesktop synced 2025-03-06 02:01:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix stack overflow crash in emoji panel hiding.

Browse source 
A call to hideChildren before setting _hiding to the desired value
could lead through leaveEvent to a recursive call to hideAnimated.
This commit is contained in:
John Preston 2019-04-30 12:56:21 +04:00
parent 5c3f93eee1
commit c9552390e7
2 changed files with 16 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
Telegram/SourceFiles/chat_helpers/tabbed_panel.cpp
View file

@ -255,15 +255,21 @@ void TabbedPanel::hideByTimerOrLeave() {
hideAnimated();
}
void TabbedPanel::prepareCache() {
if (_a_opacity.animating()) return;
void TabbedPanel::prepareCacheFor(bool hiding) {
if (_a_opacity.animating()) {
return;
}
auto showAnimation = base::take(_a_show);
auto showAnimationData = base::take(_showAnimation);
_hiding = false;
showChildren();
_cache = Ui::GrabWidget(this);
_showAnimation = base::take(showAnimationData);
_a_show = base::take(showAnimation);
_showAnimation = base::take(showAnimationData);
_hiding = hiding;
if (_a_show.animating()) {
hideChildren();
}
@ -273,11 +279,13 @@ void TabbedPanel::startOpacityAnimation(bool hiding) {
if (_selector && !_selector->isHidden()) {
_selector->beforeHiding();
}
_hiding = false;
prepareCache();
_hiding = hiding;
prepareCacheFor(hiding);
hideChildren();
_a_opacity.start([this] { opacityAnimationCallback(); }, _hiding ? 1. : 0., _hiding ? 0. : 1., st::emojiPanDuration);
_a_opacity.start(
[=] { opacityAnimationCallback(); },
_hiding ? 1. : 0.,
_hiding ? 0. : 1.,
st::emojiPanDuration);
}
void TabbedPanel::startShowAnimation() {

2
Telegram/SourceFiles/chat_helpers/tabbed_panel.h
View file

@ -77,7 +77,7 @@ private:
QImage grabForAnimation();
void startShowAnimation();
void startOpacityAnimation(bool hiding);
void prepareCache();
void prepareCacheFor(bool hiding);
void opacityAnimationCallback();