hiro/tdesktop
1
0
Fork 0
mirror of https://github.com/vale981/tdesktop synced 2025-03-06 02:01:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Better check unique results in support mode.

Browse source
This commit is contained in:
John Preston 2019-02-01 09:53:15 +03:00
parent 5a388d9dde
commit 918d58ef0a
2 changed files with 45 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

52
Telegram/SourceFiles/dialogs/dialogs_inner_widget.cpp
View file

@ -404,7 +404,7 @@ void DialogsInner::paintRegion(Painter &p, const QRegion &region, bool paintingO
}
}
}
if (!_filterResults.isEmpty()) {
if (!_filterResults.empty()) {
auto skip = filteredOffset();
auto from = floorclamp(r.y() - skip, st::dialogsRowHeight, 0, _filterResults.size());
auto to = ceilclamp(r.y() + r.height() - skip, st::dialogsRowHeight, 0, _filterResults.size());
@ -795,7 +795,7 @@ void DialogsInner::selectByMouse(QPoint globalPosition) {
}
_hashtagDeleteSelected = (_hashtagSelected >= 0) && (local.x() >= w - st::mentionHeight);
}
if (!_filterResults.isEmpty()) {
if (!_filterResults.empty()) {
auto skip = filteredOffset();
auto filteredSelected = (mouseY >= skip) ? ((mouseY - skip) / st::dialogsRowHeight) : -1;
if (filteredSelected < 0 || filteredSelected >= _filterResults.size()) {
@ -1367,7 +1367,7 @@ void DialogsInner::repaintDialogRow(
}
} else if (_state == State::Filtered) {
if (list == Dialogs::Mode::All) {
for (auto i = 0, l = _filterResults.size(); i != l; ++i) {
for (auto i = 0, l = int(_filterResults.size()); i != l; ++i) {
if (_filterResults[i]->key() == row->key()) {
update(
0,
@ -1439,7 +1439,7 @@ void DialogsInner::updateDialogRow(
}
} else if (_state == State::Filtered) {
if ((sections & UpdateRowSection::Filtered)
&& !_filterResults.isEmpty()) {
&& !_filterResults.empty()) {
const auto add = filteredOffset();
auto index = 0;
for (const auto result : _filterResults) {
@ -1503,7 +1503,7 @@ void DialogsInner::updateSelectedRow(Dialogs::Key key) {
}
} else if (_state == State::Filtered) {
if (key) {
for (auto i = 0, l = _filterResults.size(); i != l; ++i) {
for (auto i = 0, l = int(_filterResults.size()); i != l; ++i) {
if (_filterResults[i]->key() == key) {
update(0, filteredOffset() + i * st::dialogsRowHeight, getFullWidth(), st::dialogsRowHeight);
break;
@ -1928,13 +1928,33 @@ bool DialogsInner::uniqueSearchResults() const {
&& !_searchInChat;
}
bool DialogsInner::hasHistoryInSearchResults(not_null<History*> history) const {
bool DialogsInner::hasHistoryInResults(not_null<History*> history) const {
using Result = std::unique_ptr<Dialogs::FakeRow>;
return ranges::find(
const auto inSearchResults = ranges::find(
_searchResults,
history,
[](const Result &result) { return result->item()->history(); }
) != end(_searchResults);
if (inSearchResults) {
return true;
}
const auto inFilteredResults = ranges::find(
_filterResults,
history.get(),
[](Dialogs::Row *row) { return row->history(); }
) != end(_filterResults);
if (inFilteredResults) {
return true;
}
const auto inPeerSearchResults = ranges::find(
_peerSearchResults,
history->peer,
[](const auto &result) { return result->peer; }
) != end(_peerSearchResults);
if (inPeerSearchResults) {
return true;
}
return false;
}
bool DialogsInner::searchReceived(
@ -1959,7 +1979,7 @@ bool DialogsInner::searchReceived(
message,
NewMessageExisting);
const auto history = item->history();
if (!uniquePeers || !hasHistoryInSearchResults(history)) {
if (!uniquePeers || !hasHistoryInResults(history)) {
_searchResults.push_back(
std::make_unique<Dialogs::FakeRow>(
_searchInChat,
@ -2189,7 +2209,7 @@ DialogsInner::State DialogsInner::state() const {
}
bool DialogsInner::hasFilteredResults() const {
return !_filterResults.isEmpty() && _hashtagResults.empty();
return !_filterResults.empty() && _hashtagResults.empty();
}
void DialogsInner::searchInChat(Dialogs::Key key, UserData *from) {
@ -2313,14 +2333,14 @@ void DialogsInner::selectSkip(int32 direction) {
emit mustScrollTo(fromY, fromY + st::dialogsRowHeight);
}
} else if (_state == State::Filtered) {
if (_hashtagResults.empty() && _filterResults.isEmpty() && _peerSearchResults.empty() && _searchResults.empty()) return;
if (_hashtagResults.empty() && _filterResults.empty() && _peerSearchResults.empty() && _searchResults.empty()) return;
if ((_hashtagSelected < 0 || _hashtagSelected >= _hashtagResults.size()) &&
(_filteredSelected < 0 || _filteredSelected >= _filterResults.size()) &&
(_peerSearchSelected < 0 || _peerSearchSelected >= _peerSearchResults.size()) &&
(_searchedSelected < 0 || _searchedSelected >= _searchResults.size())) {
if (_hashtagResults.empty() && _filterResults.isEmpty() && _peerSearchResults.empty()) {
if (_hashtagResults.empty() && _filterResults.empty() && _peerSearchResults.empty()) {
_searchedSelected = 0;
} else if (_hashtagResults.empty() && _filterResults.isEmpty()) {
} else if (_hashtagResults.empty() && _filterResults.empty()) {
_peerSearchSelected = 0;
} else if (_hashtagResults.empty()) {
_filteredSelected = 0;
@ -2377,7 +2397,7 @@ void DialogsInner::scrollToEntry(const Dialogs::RowDescriptor &entry) {
}
}
if (fromY < 0) {
for (auto i = 0, c = _filterResults.size(); i != c; ++i) {
for (auto i = 0, c = int(_filterResults.size()); i != c; ++i) {
if (_filterResults[i]->key() == entry.key) {
fromY = filteredOffset() + (i * st::dialogsRowHeight);
break;
@ -2658,7 +2678,7 @@ Dialogs::RowDescriptor DialogsInner::chatListEntryBefore(
}
if (isSearchResultActive(_searchResults[0].get(), which)) {
if (_peerSearchResults.empty()) {
if (_filterResults.isEmpty()) {
if (_filterResults.empty()) {
return Dialogs::RowDescriptor();
}
return Dialogs::RowDescriptor(
@ -2672,7 +2692,7 @@ Dialogs::RowDescriptor DialogsInner::chatListEntryBefore(
}
if (!_peerSearchResults.empty()
&& _peerSearchResults[0]->peer == whichHistory->peer) {
if (_filterResults.isEmpty()) {
if (_filterResults.empty()) {
return Dialogs::RowDescriptor();
}
return Dialogs::RowDescriptor(
@ -2688,7 +2708,7 @@ Dialogs::RowDescriptor DialogsInner::chatListEntryBefore(
}
}
}
if (_filterResults.isEmpty() || _filterResults[0]->key() == which.key) {
if (_filterResults.empty() || _filterResults[0]->key() == which.key) {
return Dialogs::RowDescriptor();
}

23
Telegram/SourceFiles/dialogs/dialogs_inner_widget.h
View file

@ -132,13 +132,8 @@ protected:
private:
struct ImportantSwitch;
using DialogsList = std::unique_ptr<Dialogs::IndexedList>;
using FilteredDialogs = QVector<Dialogs::Row*>;
using SearchResults = std::vector<std::unique_ptr<Dialogs::FakeRow>>;
struct HashtagResult;
using HashtagResults = std::vector<std::unique_ptr<HashtagResult>>;
struct PeerSearchResult;
using PeerSearchResults = std::vector<std::unique_ptr<PeerSearchResult>>;
enum class JumpSkip {
PreviousOrBegin,
@ -190,7 +185,7 @@ private:
not_null<PeerData*> peer,
const base::flat_set<QChar> &oldLetters);
bool uniqueSearchResults() const;
bool hasHistoryInSearchResults(not_null<History*> history) const;
bool hasHistoryInResults(not_null<History*> history) const;
void setupShortcuts();
Dialogs::RowDescriptor computeJump(
@ -293,11 +288,11 @@ private:
not_null<Window::Controller*> _controller;
DialogsList _dialogs;
DialogsList _dialogsImportant;
std::unique_ptr<Dialogs::IndexedList> _dialogs;
std::unique_ptr<Dialogs::IndexedList> _dialogsImportant;
DialogsList _contactsNoDialogs;
DialogsList _contacts;
std::unique_ptr<Dialogs::IndexedList> _contactsNoDialogs;
std::unique_ptr<Dialogs::IndexedList> _contacts;
bool _mouseSelection = false;
std::optional<QPoint> _lastMousePosition;
@ -328,13 +323,13 @@ private:
int _visibleBottom = 0;
QString _filter, _hashtagFilter;
HashtagResults _hashtagResults;
std::vector<std::unique_ptr<HashtagResult>> _hashtagResults;
int _hashtagSelected = -1;
int _hashtagPressed = -1;
bool _hashtagDeleteSelected = false;
bool _hashtagDeletePressed = false;
FilteredDialogs _filterResults;
std::vector<Dialogs::Row*> _filterResults;
base::flat_map<
not_null<PeerData*>,
std::unique_ptr<Dialogs::Row>> _filterResultsGlobal;
@ -344,11 +339,11 @@ private:
bool _waitingForSearch = false;
QString _peerSearchQuery;
PeerSearchResults _peerSearchResults;
std::vector<std::unique_ptr<PeerSearchResult>> _peerSearchResults;
int _peerSearchSelected = -1;
int _peerSearchPressed = -1;
SearchResults _searchResults;
std::vector<std::unique_ptr<Dialogs::FakeRow>> _searchResults;
int _searchedCount = 0;
int _searchedMigratedCount = 0;
int _searchedSelected = -1;