From ea240dffc10794a49085d7590dc9f1560b127b21 Mon Sep 17 00:00:00 2001
From: Valentin Boettcher <hiro@protagon.space>
Date: Fri, 14 Aug 2020 18:53:21 +0200
Subject: [PATCH] slightly dirty tric to pass the test

---
 src/stream/commander/api.clj   | 15 +++++++++------
 test/stream/commander_test.clj |  8 +++-----
 2 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/src/stream/commander/api.clj b/src/stream/commander/api.clj
index 0195bd2..e61f57e 100644
--- a/src/stream/commander/api.clj
+++ b/src/stream/commander/api.clj
@@ -137,6 +137,12 @@
                                         ;              Monitoring             ;
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 
+(defn- put-process-event!
+  [id data]
+  (a/put! master-monitor {:type :process-event
+                          :id id
+                          :event data}))
+
 (defn- handle-process-error!
   [event id]
   (when-let [proc (get-process! id)]
@@ -146,6 +152,9 @@
             :start-failed (diagnose-start-error (:message (:details event)) proc)
             nil)]
 
+      (put-process-event! id {:type :new-problem
+                              :problem problem})
+
       (dosync
        (alter processes
               (fn [procs]
@@ -153,12 +162,6 @@
                       updated-proc (assoc proc :problems (conj (:problems proc) problem))]
                   (assoc procs id updated-proc))))))))
 
-(defn- put-process-event!
-  [id data]
-  (a/put! master-monitor {:type :process-event
-                          :id id
-                          :event data}))
-
 (defn- handle-status-event!
   "Handles status `event`s from the process with the `id`."
   [id event]
diff --git a/test/stream/commander_test.clj b/test/stream/commander_test.clj
index 8c5d5e7..b8648a5 100644
--- a/test/stream/commander_test.clj
+++ b/test/stream/commander_test.clj
@@ -42,10 +42,6 @@
       (testing "starting a process (which will fail)"
         (is (not (:success @(p/start! proc)))))
 
-      (testing "problem diagnosis"
-        (is ((:problems (api/get-process! (:id proc)))
-             :ffmpeg-not-found)))
-
       (testing "spilling junk into the monitor channel"
         (a/>!! (:monitor proc) "junk"))
 
@@ -61,7 +57,9 @@
         (let [c (a/chan)]
           (a/sub api/monitor :process-event c)
           (p/start! proc)
-          (is (= (:id proc) (:id (a/<!! c))))))
+          (is (= (:id proc) (:id (a/<!! c))))
+          (is ((:problems (api/get-process! (:id proc)))
+             :ffmpeg-not-found))))
 
       (testing "deleting the process"
         (is (api/delete-process! proc))