hiro/releases
1
0
Fork 0
mirror of https://github.com/vale981/releases synced 2025-03-05 17:51:42 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Now _releases has no need to be a method

Browse source
This commit is contained in:
Jeff Forcier 2013-11-20 14:48:18 -08:00
parent 5b01391183
commit f66c6f2e69
1 changed files with 17 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
tests/changelog.py
View file

@ -33,6 +33,18 @@ def _app():
app.config = config
return app
def _releases(*entries):
entries = list(entries) # lol tuples
# Translate simple objs into changelog-friendly ones
for index, item in enumerate(entries):
if isinstance(item, basestring):
entries[index] = _release(item)
else:
entries[index] = _entry(item)
# Insert initial/empty 1st release to start timeline
entries.append(_release('1.0.0'))
return construct_releases(entries, _app())
class releases(Spec):
"""
@ -46,21 +58,9 @@ class releases(Spec):
self.bf = _issue('feature', '27', backported=True)
self.bs = _issue('support', '29', backported=True)
def _releases(self, *entries):
entries = list(entries) # lol tuples
# Translate simple objs into changelog-friendly ones
for index, item in enumerate(entries):
if isinstance(item, basestring):
entries[index] = _release(item)
else:
entries[index] = _entry(item)
# Insert initial/empty 1st release to start timeline
entries.append(_release('1.0.0'))
return construct_releases(entries, _app())
def _expect_entries(self, all_entries, in_, not_in):
# Grab 2nd release as 1st is the empty 'beginning of time' one
entries = self._releases(*all_entries)[1]['entries']
entries = _releases(*all_entries)[1]['entries']
eq_(len(entries), len(in_))
for x in in_:
assert x in entries
@ -105,21 +105,21 @@ class releases(Spec):
def unmarked_bullet_list_items_treated_as_bugs(self):
# Empty list item here stands in for just-a-list-of-nodes,
# which is what a non-issue/release changelog list item looks like
entries = self._releases('1.0.2', self.f, [])[1]['entries']
entries = _releases('1.0.2', self.f, [])[1]['entries']
eq_(len(entries), 1)
assert self.f not in entries
assert isinstance(entries[0], issue)
eq_(entries[0].number, None)
def unreleased_items_go_in_unreleased_release(self):
releases = self._releases('1.0.2', self.f, self.b)
releases = _releases('1.0.2', self.f, self.b)
r = releases[-1]
eq_(len(r['entries']), 1)
assert self.f in r['entries']
eq_(r['obj'].number, 'unreleased')
def issues_consumed_by_releases_are_not_in_unreleased(self):
releases = self._releases('1.0.2', self.f, self.b, self.s, self.bs)
releases = _releases('1.0.2', self.f, self.b, self.s, self.bs)
release = releases[1]['entries']
unreleased = releases[-1]['entries']
assert self.b in release
@ -127,7 +127,7 @@ class releases(Spec):
def unreleased_catches_bugs_and_features(self):
entries = [self.f, self.b, self.mb, self.s, self.bs, self.bf]
releases = self._releases(*entries)
releases = _releases(*entries)
unreleased = releases[-1]['entries']
for x in entries:
assert x in unreleased