mirror of
https://github.com/vale981/ray
synced 2025-03-10 05:16:49 -04:00
ed34434131
Current logs API simply returns a str to unblock development and integration. We should add proper log streaming for better UX and external job manager integration. Co-authored-by: Sven Mika <sven@anyscale.io> Co-authored-by: sven1977 <svenmika1977@gmail.com> Co-authored-by: Ed Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Richard Liaw <rliaw@berkeley.edu> Co-authored-by: Simon Mo <simon.mo@hey.com> Co-authored-by: Avnish Narayan <38871737+avnishn@users.noreply.github.com> Co-authored-by: Jiao Dong <jiaodong@anyscale.com>
60 lines
1.9 KiB
Python
60 lines
1.9 KiB
Python
import logging
|
|
|
|
import pytest
|
|
import sys
|
|
import os
|
|
import subprocess
|
|
import uuid
|
|
from contextlib import contextmanager
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
@contextmanager
|
|
def conda_env(env_name):
|
|
# Set env name for shell script
|
|
os.environ["JOB_COMPATIBILITY_TEST_TEMP_ENV"] = env_name
|
|
# Delete conda env if it already exists
|
|
try:
|
|
yield
|
|
finally:
|
|
# Clean up created conda env upon test exit to prevent leaking
|
|
del os.environ["JOB_COMPATIBILITY_TEST_TEMP_ENV"]
|
|
subprocess.run(
|
|
f"conda env remove -y --name {env_name}",
|
|
shell=True,
|
|
stdout=subprocess.PIPE)
|
|
|
|
|
|
def _compatibility_script_path(file_name: str) -> str:
|
|
return os.path.join(
|
|
os.path.dirname(__file__), "backwards_compatibility_scripts",
|
|
file_name)
|
|
|
|
|
|
class TestBackwardsCompatibility:
|
|
def test_cli(self):
|
|
"""
|
|
1) Create a new conda environment with ray version X installed
|
|
inherits same env as current conda envionment except ray version
|
|
2) Start head node and dashboard with ray version X
|
|
3) Use current commit's CLI code to do sample job submission flow
|
|
4) Deactivate the new conda environment and back to original place
|
|
"""
|
|
# Shell script creates and cleans up tmp conda environment regardless
|
|
# of the outcome
|
|
env_name = f"jobs-backwards-compatibility-{uuid.uuid4().hex}"
|
|
with conda_env(env_name):
|
|
shell_cmd = f"{_compatibility_script_path('test_backwards_compatibility.sh')}" # noqa: E501
|
|
|
|
try:
|
|
subprocess.check_output(
|
|
shell_cmd, shell=True, stderr=subprocess.STDOUT)
|
|
except subprocess.CalledProcessError as e:
|
|
logger.error(str(e))
|
|
logger.error(e.stdout.decode())
|
|
raise e
|
|
|
|
|
|
if __name__ == "__main__":
|
|
sys.exit(pytest.main(["-v", __file__]))
|