mirror of
https://github.com/vale981/ray
synced 2025-03-06 10:31:39 -05:00
331b71ea8d
Adds a unit-tested and restructured ray_release package for running release tests.
Relevant changes in behavior:
Per default, Buildkite will wait for the wheels of the current commit to be available. Alternatively, users can a) specify a different commit hash, b) a wheels URL (which we will also wait for to be available) or c) specify a branch (or user/branch combination), in which case the latest available wheels will be used (e.g. if master is passed, behavior matches old default behavior).
The main subpackages are:
Cluster manager: Creates cluster envs/computes, starts cluster, terminates cluster
Command runner: Runs commands, e.g. as client command or sdk command
File manager: Uploads/downloads files to/from session
Reporter: Reports results (e.g. to database)
Much of the code base is unit tested, but there are probably some pieces missing.
Example build (waited for wheels to be built): https://buildkite.com/ray-project/kf-dev/builds/51#_
Wheel build: https://buildkite.com/ray-project/ray-builders-branch/builds/6023
66 lines
2 KiB
Python
66 lines
2 KiB
Python
from typing import Optional
|
|
|
|
from ray_release.config import Test
|
|
from ray_release.result import Result
|
|
|
|
|
|
def handle_result(
|
|
test: Test,
|
|
result: Result,
|
|
) -> Optional[str]:
|
|
test_name = test["legacy"]["test_name"]
|
|
|
|
time_taken = result.results.get("time_taken", float("inf"))
|
|
num_terminated = result.results.get("trial_states", {}).get("TERMINATED", 0)
|
|
|
|
if test_name in ["distributed_api_test", "ft_small_elastic", "ft_small_nonelastic"]:
|
|
if not result.status == "finished":
|
|
return f"Test script did not finish successfully ({result.status})."
|
|
|
|
return None
|
|
elif test_name.startswith("tune_"):
|
|
msg = ""
|
|
if test_name == "tune_small":
|
|
target_terminated = 4
|
|
target_time = 90
|
|
elif test_name == "tune_4x32":
|
|
target_terminated = 4
|
|
target_time = 120
|
|
elif test_name == "tune_32x4":
|
|
target_terminated = 32
|
|
target_time = 600
|
|
else:
|
|
return None
|
|
|
|
if num_terminated < target_terminated:
|
|
msg += (
|
|
f"Some trials failed "
|
|
f"(num_terminated={num_terminated} < {target_terminated}). "
|
|
)
|
|
if time_taken > target_time:
|
|
msg += (
|
|
f"Took too long to complete "
|
|
f"(time_taken={time_taken} > {target_time}). "
|
|
)
|
|
|
|
return msg or None
|
|
else:
|
|
# train scripts
|
|
if test_name == "train_small":
|
|
# Leave a couple of seconds for ray connect setup
|
|
# (without connect it should finish in < 30)
|
|
target_time = 45
|
|
elif test_name == "train_moderate":
|
|
target_time = 60
|
|
elif test_name == "train_gpu":
|
|
target_time = 40
|
|
else:
|
|
return None
|
|
|
|
if time_taken > target_time:
|
|
return (
|
|
f"Took too long to complete "
|
|
f"(time_taken={time_taken:.2f} > {target_time}). "
|
|
)
|
|
|
|
return None
|