mirror of
https://github.com/vale981/ray
synced 2025-03-11 21:56:39 -04:00
7c3274e65b
## What do these changes do?
This is a re-implementation of the `FunctionRunner` which enforces some synchronicity between the thread running the training function and the thread running the Trainable which logs results. The main purpose is to make logging consistent across APIs in anticipation of a new function API which will be generator based (through `yield` statements). Without these changes, it will be impossible for the (possibly soon to be) deprecated reporter based API to behave the same as the generator based API.
This new implementation provides additional guarantees to prevent results from being dropped. This makes the logging behavior more intuitive and consistent with how results are handled in custom subclasses of Trainable.
New guarantees for the tune function API:
- Every reported result, i.e., `reporter(**kwargs)` calls, is forwarded to the appropriate loggers instead of being dropped if not enough time has elapsed since the last results.
- The wrapped function only runs if the `FunctionRunner` expects a result, i.e., when `FunctionRunner._train()` has been called. This removes the possibility that a result will be generated by the function but never logged.
- The wrapped function is not called until the first `_train()` call. Currently, the wrapped function is started during the setup phase which could result in dropped results if the trial is cancelled between `_setup()` and the first `_train()` call.
- Exceptions raised by the wrapped function won't be propagated until all results are logged to prevent dropped results.
- The thread running the wrapped function is explicitly stopped when the `FunctionRunner` is stopped with `_stop()`.
- If the wrapped function terminates without reporting `done=True`, a duplicate result with `{"done": True}`, is reported to explicitly terminate the trial, and components will be notified with a duplicate of the last reported result, but this duplicate will not be logged.
## Related issue number
Closes #3956.
#3949
#3834
|
||
|---|---|---|
| .. | ||
| autoscaler | ||
| cloudpickle | ||
| core | ||
| dashboard | ||
| dataframe | ||
| experimental | ||
| includes | ||
| internal | ||
| pyarrow_files | ||
| rllib | ||
| scripts | ||
| tests | ||
| tune | ||
| workers | ||
| __init__.py | ||
| _raylet.pyx | ||
| actor.py | ||
| exceptions.py | ||
| function_manager.py | ||
| gcs_utils.py | ||
| import_thread.py | ||
| log_monitor.py | ||
| memory_monitor.py | ||
| monitor.py | ||
| node.py | ||
| parameter.py | ||
| profiling.py | ||
| ray_constants.py | ||
| remote_function.py | ||
| reporter.py | ||
| runtime_context.py | ||
| serialization.py | ||
| services.py | ||
| signature.py | ||
| utils.py | ||
| worker.py | ||