mirror of
https://github.com/vale981/ray
synced 2025-03-10 05:16:49 -04:00
5ce79d0a46
* [job submission] Use specific redis_address and redis_password instead of "auto" (#20687) Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Jiao Dong <jiaodong@anyscale.com>
107 lines
3.8 KiB
Python
107 lines
3.8 KiB
Python
from contextlib import contextmanager
|
|
import os
|
|
import logging
|
|
import sys
|
|
import subprocess
|
|
from typing import Optional
|
|
|
|
import pytest
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
@contextmanager
|
|
def set_env_var(key: str, val: Optional[str] = None):
|
|
old_val = os.environ.get(key, None)
|
|
if val is not None:
|
|
os.environ[key] = val
|
|
elif key in os.environ:
|
|
del os.environ[key]
|
|
|
|
yield
|
|
|
|
if key in os.environ:
|
|
del os.environ[key]
|
|
if old_val is not None:
|
|
os.environ[key] = old_val
|
|
|
|
|
|
@pytest.fixture
|
|
def ray_start_stop():
|
|
subprocess.check_output(["ray", "start", "--head"])
|
|
yield
|
|
subprocess.check_output(["ray", "stop", "--force"])
|
|
|
|
|
|
@contextmanager
|
|
def ray_cluster_manager():
|
|
"""
|
|
Used not as fixture in case we want to set RAY_ADDRESS first.
|
|
"""
|
|
subprocess.check_output(["ray", "start", "--head"])
|
|
yield
|
|
subprocess.check_output(["ray", "stop", "--force"])
|
|
|
|
|
|
class TestSubmitIntegration:
|
|
"""
|
|
Integration version of job CLI test that ensures interaction with the
|
|
following components are working as expected:
|
|
|
|
1) Ray client: use of RAY_ADDRESS and ray.init() in job_head.py
|
|
2) Ray dashboard: `ray start --head`
|
|
"""
|
|
|
|
def test_empty_ray_address(self, ray_start_stop):
|
|
with set_env_var("RAY_ADDRESS", None):
|
|
completed_process = subprocess.run(
|
|
["ray", "job", "submit", "--", "echo hello"],
|
|
stderr=subprocess.PIPE)
|
|
stderr = completed_process.stderr.decode("utf-8")
|
|
# Current dashboard module that raises no exception from requests..
|
|
assert ("Address must be specified using either the "
|
|
"--address flag or RAY_ADDRESS environment") in stderr
|
|
|
|
def test_ray_client_adress(self, ray_start_stop):
|
|
with set_env_var("RAY_ADDRESS", "127.0.0.1:8265"):
|
|
completed_process = subprocess.run(
|
|
["ray", "job", "submit", "--", "echo hello"],
|
|
stderr=subprocess.PIPE)
|
|
stderr = completed_process.stderr.decode("utf-8")
|
|
# Current dashboard module that raises no exception from requests..
|
|
assert "Query the status of the job" in stderr
|
|
|
|
def test_valid_http_ray_address(self, ray_start_stop):
|
|
with set_env_var("RAY_ADDRESS", "http://127.0.0.1:8265"):
|
|
completed_process = subprocess.run(
|
|
["ray", "job", "submit", "--", "echo hello"],
|
|
stderr=subprocess.PIPE)
|
|
stderr = completed_process.stderr.decode("utf-8")
|
|
# Current dashboard module that raises no exception from requests..
|
|
assert "Query the status of the job" in stderr
|
|
|
|
def test_set_ray_http_address_first(self):
|
|
with set_env_var("RAY_ADDRESS", "http://127.0.0.1:8265"):
|
|
with ray_cluster_manager():
|
|
completed_process = subprocess.run(
|
|
["ray", "job", "submit", "--", "echo hello"],
|
|
stderr=subprocess.PIPE)
|
|
stderr = completed_process.stderr.decode("utf-8")
|
|
# Current dashboard module that raises no exception from
|
|
# requests..
|
|
assert "Query the status of the job" in stderr
|
|
|
|
def test_set_ray_client_address_first(self):
|
|
with set_env_var("RAY_ADDRESS", "127.0.0.1:8265"):
|
|
with ray_cluster_manager():
|
|
completed_process = subprocess.run(
|
|
["ray", "job", "submit", "--", "echo hello"],
|
|
stderr=subprocess.PIPE)
|
|
stderr = completed_process.stderr.decode("utf-8")
|
|
# Current dashboard module that raises no exception from
|
|
# requests..
|
|
assert "Query the status of the job" in stderr
|
|
|
|
|
|
if __name__ == "__main__":
|
|
sys.exit(pytest.main(["-v", __file__]))
|