Commit graph

13494 commits

Author SHA1 Message Date
Chen Shen
fe9a12aa92
Revert "[KubeRay][Autoscaler][Core] Add a flag to disable ray status version check (#26584)" (#26597)
Reverts #26584

Seems it breaking test_advanced_4
2022-07-15 15:47:28 -07:00
Richard Liaw
5ad4e75831
[air] Add initial benchmark section (#26608) 2022-07-15 15:33:48 -07:00
Siyuan (Ryans) Zhuang
964bc90e09
[Workflow] Remove workflow execution module (#26504)
* remove workflow execution module

Signed-off-by: Siyuan <suquark@gmail.com>
2022-07-15 14:52:03 -07:00
xwjiang2010
a241e6a0f5
[air] Add xgboost release test for silver tier(10-node case). (#26460)
Co-authored-by: Antoni Baum <antoni.baum@protonmail.com>
Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
2022-07-15 13:21:10 -07:00
Edward Oakes
0ecc7dad74
Revert "Revert "[serve] Use soft constraint for pinning controller on head node (#25091)" (#25857)" (#25858) 2022-07-15 14:07:24 -05:00
Artur Niederfahrenhorst
4ce9686d94
[RLlib] Fixes MARWIL release tests (#26586) 2022-07-15 11:13:15 -07:00
Cheng Su
5a95e11e1e
[Datasets] Improve read_xxx experience of HTTP file (#26454) 2022-07-15 10:39:39 -07:00
Qing Wang
e301f9b543
Cleanup ActorContext due to multi actor instances got removed. (#26497) 2022-07-15 23:30:09 +08:00
michalsustr
ca3d272c3e
Print newest_ckpt_path when resuming trial. (#26561)
When trail is resumed, it is useful for the user to know from which checkpoint it happened.

Signed-off-by: sustr-equi <sustr@equilibretechnologies.com>
Co-authored-by: sustr-equi <sustr@equilibretechnologies.com>
2022-07-15 10:52:50 +01:00
Hao Chen
8fd0d39f06
Fix test_serialization_error_message for pytest 6.x (#26591) 2022-07-15 17:37:14 +08:00
Ishant Mrinal
57244aeee3
[RLlib] Make DQN update_target use only trainable variables. (#25226) 2022-07-15 09:17:06 +02:00
mgerstgrasser
f0e9d1a9bb
[RLlib] In env check, step only expected agents. (#26425) 2022-07-15 09:16:09 +02:00
Sven Mika
4aea24c8a8
[RLlib] restart_failed_sub_environments now works for MA cases and crashes during reset(); +more tests and logging; add eval worker sub-env fault tolerance test. (#26276) 2022-07-15 08:55:14 +02:00
Guyang Song
1949f35901
[runtime env] plugin refactor[4/n]: remove runtime env protobuf (#26522) 2022-07-15 13:56:12 +08:00
Clark Zinzow
5a81871820
Improve streaming read performance for default configuration. (#26587)
Signed-off-by: Clark Zinzow <clarkzinzow@gmail.com>
2022-07-14 21:25:21 -07:00
brucez-anyscale
d98a2482de
[Dashboard] Fix test dashboard flaky by catch an expected exception (#26555) 2022-07-14 20:57:46 -07:00
Simon Mo
df9f891416
[Serve] User custom class name for replica class (#26574) 2022-07-14 20:10:56 -07:00
Dmitri Gekhtman
a304d1c145
[KubeRay][Autoscaler][Core] Add a flag to disable ray status version check (#26584)
Adds a flag that disables the version check in ray health-check.
2022-07-14 19:56:16 -07:00
Tao Wang
6ddbdaa81a
[CI]Split C++, Java tests in MacOS from the big one (#26434) 2022-07-14 18:33:47 -07:00
Simon Mo
ef1d5c9a97
[Serve][AIR] Fix pandas_read_json compatibility issue (#26494) 2022-07-14 15:29:14 -07:00
Jiao
469ec195be
fix lint (#26569)
e9f6ffc broke it with logs
2022-07-14 15:07:02 -07:00
Jiao
647e12b6c7
[AIR] Fix convert_existing_pytorch_code_to_ray_air notebook (#26523) 2022-07-14 14:30:55 -07:00
Kai Fricke
213a96e239
[air/benchmarks] Add distributed Tensorflow benchmarks (CPU only) (#26519)
Following up from #26436, this PR adds a distributed benchmark test for Tensorflow FashionMNIST training. It compares training with Ray AIR with training with vanilla PyTorch.

Signed-off-by: Kai Fricke <kai@anyscale.com>
2022-07-14 22:08:43 +01:00
Antoni Baum
7cc6542205
[AIR/Train] HuggingFacePredictor improvements (#26531)
Co-authored-by: Amog Kamsetty <amogkam@users.noreply.github.com>
2022-07-14 13:20:31 -07:00
Antoni Baum
4273d2235e
[AIR] Improve to_air_checkpoint with path (#26532) 2022-07-14 13:20:21 -07:00
Eric Liang
40be6904a5
[data] Avoid under-parallelization regressions and add better testing for parallelism detection (#26543)
In the previous PR #25883, a subtle regression was introduced in the case where data sizes blow up significantly.

For example, suppose you're reading jpeg-image files from a Dataset, which increase in size substantially on decompression. On a small-core cluster (e.g., 4 cores), you end up with 4-8 blocks of ~200MiB each when reading a 1GiB dataset. This can blow up to OOM the node when decompressed (e.g., 25x size increase).

Previously the heuristic to use parallelism=200 avoids this small-node problem. This PR avoids this issue by (1) raising the min parallelism back to 200. As an optimization, we also introduce the min block size threshold, which allows using fewer blocks if the data size is really small (<100KiB per block).
2022-07-14 13:02:52 -07:00
Tim Gates
e42dc7943e
docs: Fix a few typos (#26556)
There are small typos in:
- doc/source/data/faq.rst
- python/ray/serve/replica.py

Fixes:
- Should read `successfully` rather than `succssifully`.
- Should read `pseudo` rather than `psuedo`.
2022-07-14 12:38:33 -07:00
Jiajun Yao
60dd77a2d3
Enable usage stats collection for ray.init iff nightly wheels (#26461)
For nightly wheels, we want to collect usage stats for local clusters started via ray.init() as well.
2022-07-14 12:14:01 -07:00
Amog Kamsetty
6595bd6e2d
[AIR] Introduce better scoring API for BatchPredictor (#26451)
Signed-off-by: Amog Kamsetty <amogkamsetty@yahoo.com>

As discussed offline, allow configurability for feature columns and keep columns in BatchPredictor for better scoring UX on test datasets.
2022-07-14 11:26:12 -07:00
Richard Liaw
a0ce3c111b
[air/data] Concatenator preprocessor (#26526) 2022-07-14 10:26:14 -07:00
Avnish Narayan
a322ac463c
[RLlib] Make JSONReader default, users will have to use the DatasetReader for any speedups. (#26541) 2022-07-14 17:19:38 +02:00
Antoni Baum
c168c09281
[Tune] Restore old max concurrent logic in BOHB (#26529)
As discussed on Ray Slack (https://ray-distributed.slack.com/archives/CNECXMW22/p1657051287814569), the changes introduced in #18770 and #20822 have caused the concurrency limiting logic in BOHB to work incorrectly. This PR restores the old logic, while making use of the set_max_concurrency API (as eg. HEBO), maintaining backwards compatibility.

It should be noted that the old logic this PR reintroduces is essentially a hack and should be refactored in the future. This PR is intended to rapidly fix a bug causing search performance to be suboptimal.

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>

Co-authored-by: Kai Fricke <krfricke@users.noreply.github.com>
2022-07-14 15:40:51 +01:00
Ricky Xu
c54916bc0f
[Core | State Observability] Add feedback prompt for dogfooding alpha (#26450)
Embed console print to gather dogfooding feedback. 

With CLIs: 
```
(dev) ➜  ray git:(ricky/obs-feedback) ray list --help
Usage: ray list [OPTIONS] {actors|jobs|placement-
                groups|nodes|workers|tasks|objects|runtime-envs}

      List RESOURCE used by Ray.

      RESOURCE is the name of the possible resources from `StateResource`,
      i.e. 'jobs', 'actors', 'nodes', ...



  ==========ALPHA PREVIEW, FEEDBACK NEEDED ===============

  State Observability APIs is currently in Alpha-Preview.

  If you have any feedback, you could do so at either way as below:

    1. Comment on API specification: https://tinyurl.com/api-spec

    2. Report bugs/issues with details: https://forms.gle/gh77mwjEskjhN8G46

    3. Follow up in #proj-state-obs-dogfooding slack channel.

  ==========================================================
```


With running SDK python api:
```
In [3]: from ray.experimental.state.api import list_nodes
In [6]: list_nodes()
2022-07-11 19:45:18,973 INFO api.py:69 -- 
==========ALPHA PREVIEW, FEEDBACK NEEDED ===============
State Observability APIs is currently in Alpha-Preview. 
If you have any feedback, you could do so at either way as below:
  1. Comment on API specification: https://tinyurl.com/api-spec
  2. Report bugs/issues with details: https://forms.gle/gh77mwjEskjhN8G46
  3. Follow up in #proj-state-obs-dogfooding slack channel.
==========================================================
Out[6]: 
[{'node_name': '172.31.47.143',
  'node_ip': '172.31.47.143',
  'resources_total': {'CPU': 8.0,
   'object_store_memory': 9149783654.0,
   'memory': 18299567310.0,
   'node:172.31.47.143': 1.0},
  'node_id': '513a3ca212403d234f6dfbe1f7523052637a06e0ee9e4502144f2da3',
  'state': 'ALIVE'}]

```
2022-07-14 06:45:07 -07:00
SangBin Cho
e9f6ffc5a5
[Core][State Observability] Use address arg + print warning if API responds slowly (#26008)
This PR is doing 2 things.

(1) Use api_server_url to address which is consistent to other submission APIs.
(2) When the API is not responded timely, it prints a warning every 5 seconds. Below is an example. This is useful when the API is slowly responded (e.g., when there are partial failures). Without this users will see hanging API for 30 seconds, which is a pretty bad UX.

(0.12 / 10 seconds) Waiting for the response from the API server address http://127.0.0.1:8265/api/v0/delay/5.
2022-07-14 06:44:07 -07:00
Antoni Baum
8f74e1f3ae
[AIR] Use cls in from_checkpoint (#26534)
Uses `cls` in `from_checkpoint` classmethods for better subclass development experience.
2022-07-14 00:15:48 -07:00
Cheng Su
f852ec82bf
[Datasets] Fix Parquet in-memory file size estimation (#26516) 2022-07-13 23:32:13 -07:00
Eric Liang
5f18c67ba3
Fix LINT (#26554)
Signed-off-by: Eric Liang <ekhliang@gmail.com>
2022-07-13 23:28:02 -07:00
Eric Liang
f2401a14d9
[air] Explicitly list out the args for BatchPredictor.predict_pipelined (#26551)
Signed-off-by: Eric Liang <ekhliang@gmail.com>
2022-07-13 22:30:32 -07:00
Jiao
15dbc0362a
[AIR][Docs] Fix torch_image_example (#26453) 2022-07-13 21:59:24 -07:00
Scott Cheng
1bc44c13fb
Update Python3.10 in docs (#26463)
Make it clear to users that ray supports Python 3.10
2022-07-13 20:08:56 -07:00
Eric Liang
31c8c908f9
[docs] Improve AIR API ref organization (#26530) 2022-07-13 18:05:17 -07:00
Kai Fricke
cd95569b01
[tune/release] Add up/down scaling release test (#25392)
This adds a nightly release test that asserts that autoscaling a cluster up and down in a Ray Tune run works.

Signed-off-by: Kai Fricke <kai@anyscale.com>
2022-07-13 22:57:24 +01:00
Stephanie Wang
6ef26cd8ff
[core] Cancel pending dependency resolution before failing a task (#26267)
Actor tasks are sometimes failed while their dependencies are still being resolved. This can cause hanging or crashes when we resolve the dependencies for a task that has already been canceled. It can lead to a crash from the ref counter when, for the same actor, actor task 1 depends on actor task 2. The sequence is:

    Actor tasks 1 and 2 queued, 1 depends on 2.
    Fail actor task 1. We clear its refs, including its dependency on 2.
    Fail actor task 2. We store an error as its return value. Since task 1 depends on it, we inline the dependency and try to clear task 1's refs again, causing a ref counting error because we already cleared them in step 2.

This PR fixes the issue by canceling dependency resolution for tasks before failing them. This involves some refactoring of the LocalDependencyResolver. Most of the changes are for testing (split out the unit tests for LocalDependencyResolver into their own suite).
Related issue number

Closes #18908.
2022-07-13 14:39:11 -07:00
Sihan Wang
b606169cb5
[Serve] Promote autoscaling feature (#26393)
1. get rid of the private attribute
2. fix unit test
3. docs and workflows
2022-07-13 14:38:38 -05:00
Sven Mika
ab10890e90
Revert "Bump pytest from 5.4.3 to 7.0.1" (breaks lots of RLlib tests for unknown reasons) (#26517) 2022-07-13 11:19:30 -07:00
Antoni Baum
cc7115f6a2
[Tune/CI] Fix tune-sklearn notebook example (#26470)
Fixes the tune-sklearn notebook example as found in #26410

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
2022-07-13 18:14:36 +01:00
Jun Gong
104407a6e5
[RLlib] Fix all the erroneous on_trainer_init warning. (#26433) 2022-07-13 18:56:01 +02:00
Jun Gong
b383d987d1
[RLlib] Fix a bunch of issues related to connectors. (#26510) 2022-07-13 18:55:20 +02:00
Sihan Wang
e2cac0b324
[Serve][Part1] Update the tests to use graph deploy (#26310) 2022-07-13 09:53:51 -07:00
Antoni Baum
5ed10ef921
[AIR/CI] Fix Hugging Face notebook example (#26475) 2022-07-13 09:16:42 -07:00