Commit graph

29 commits

Author SHA1 Message Date
mehrdadn
b62ec7787f
Ignore grep exit code for shellcheck in format.sh (#9861)
Co-authored-by: Mehrdad <noreply@github.com>
2020-08-02 00:59:05 -07:00
mehrdadn
78995d085f
Fix macOS incompatibility in format.sh (#9832)
Co-authored-by: Mehrdad <noreply@github.com>
2020-07-31 09:25:55 -07:00
mehrdadn
a7b97b6f8a
Add shellcheck support (#8574) 2020-07-30 18:39:28 -05:00
Sven Mika
b0b0463161
[RLlib] Trajectory View API (preparatory cleanup and enhancements). (#9678) 2020-07-29 21:15:09 +02:00
mehrdadn
56d2cf6479
Shellcheck rewrites (#9597)
* Fix SC2001: See if you can use ${variable//search/replace} instead.

* Fix SC2010: Don't use ls | grep. Use a glob or a for loop with a condition to allow non-alphanumeric filenames.

* Fix SC2012: Use find instead of ls to better handle non-alphanumeric filenames.

* Fix SC2015: Note that A && B || C is not if-then-else. C may run when A is true.

* Fix SC2028: echo may not expand escape sequences. Use printf.

* Fix SC2034: variable appears unused. Verify use (or export if used externally).

* Fix SC2035: Use ./*glob* or -- *glob* so names with dashes won't become options.

* Fix SC2071: > is for string comparisons. Use -gt instead.

* Fix SC2154: variable is referenced but not assigned

* Fix SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

* Fix SC2188: This redirection doesn't have a command. Move to its command (or use 'true' as no-op).

* Fix SC2236: Use -n instead of ! -z.

* Fix SC2242: Can only exit with status 0-255. Other data should be written to stdout/stderr.

* Fix SC2086: Double quote to prevent globbing and word splitting.

Co-authored-by: Mehrdad <noreply@github.com>
2020-07-24 17:24:19 -05:00
mehrdadn
b14728d999
Shellcheck quoting (#9596)
* Fix SC2006: Use $(...) notation instead of legacy backticked `...`.

* Fix SC2016: Expressions don't expand in single quotes, use double quotes for that.

* Fix SC2046: Quote this to prevent word splitting.

* Fix SC2053: Quote the right-hand side of == in [[ ]] to prevent glob matching.

* Fix SC2068: Double quote array expansions to avoid re-splitting elements.

* Fix SC2086: Double quote to prevent globbing and word splitting.

* Fix SC2102: Ranges can only match single chars (mentioned due to duplicates).

* Fix SC2140: Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A\"B\"C"?

* Fix SC2145: Argument mixes string and array. Use * or separate argument.

* Fix SC2209: warning: Use var=$(command) to assign output (or quote to assign string).

Co-authored-by: Mehrdad <noreply@github.com>
2020-07-21 21:56:41 -05:00
tison
ffeab5d2bf
Support configurable python executable in format.sh (#7513) 2020-03-14 12:27:41 -07:00
Amog Kamsetty
1737a113be
[Parallel Iterators] Repartition functionality (#7163)
* repartition and tests

* blacklist lib/ files from import checks

* addressing comments and splitting up tests

* code readability

* adding explicit ref for parent iterator

* formatting
2020-02-21 13:20:18 -08:00
Simon Mo
b804d40c04
Stop vendoring pyarrow (#7233) 2020-02-19 19:01:26 -08:00
Simon Mo
7bef7031c2
Revert "Revert "Revert "Removing Pyarrow dependency (#7146)" (#7209) (#7214)" (#7232) 2020-02-19 13:35:29 -08:00
Simon Mo
e8941b1b79
Revert "Revert "Removing Pyarrow dependency (#7146)" (#7209) (#7214) 2020-02-19 10:08:52 -08:00
Eric Liang
0aa9373d62
Revert "Removing Pyarrow dependency (#7146)" (#7209)
This reverts commit 2116fd3bca.
2020-02-18 14:12:06 -08:00
ijrsvt
2116fd3bca
Removing Pyarrow dependency (#7146) 2020-02-17 18:00:13 -08:00
Simon Mo
0ddc389830
Fix documentation building with psutil issue (#7077) 2020-02-11 10:00:29 -08:00
ijrsvt
0826f95e1c
Including psutil & setproctitle (#7031) 2020-02-05 14:16:58 -08:00
SangBin Cho
c9f5def56a
Show lint download commands if tools not installed (#6984) 2020-01-31 10:42:09 -08:00
Chaokun Yang
6272907a57 [Streaming] Streaming data transfer and python integration (#6185) 2019-12-10 20:33:24 +08:00
Eric Liang
f3f86385d6
Minimal implementation of direct task calls (#6075) 2019-11-12 11:45:28 -08:00
Edward Oakes
07c4c6367a [core worker] Python core worker object interface (#5272) 2019-09-12 23:07:46 -07:00
Simon Mo
50b93bf179 Check upstream with git remote (#5377) 2019-08-06 17:30:33 -07:00
Eric Liang
d58b986858
[rllib] MultiCategorical shouldn't return array for kl or entropy (#5215)
* wip

* fix
2019-07-19 12:12:04 -07:00
Eric Liang
047f4ccd61
[rllib] Fix rollout.py with tuple action space (#5201)
* fix it

* update doc too

* fix rollout
2019-07-16 10:52:35 -07:00
Joey Jiang
b4e51c8aa1 Support clang-format whose version is not 7.0 (#5139) 2019-07-08 17:15:09 +08:00
Robert Nishihara
9cc4cc6a52
Fail format.sh if yapf/flake8 versions are incorrect. (#5083) 2019-07-04 23:22:01 -07:00
Eric Liang
34d054ff19
[rllib] ModelV2 API (#4926) 2019-07-03 15:59:47 -07:00
justinwyang
2f4b784d0e Fixe flakequotes to allow escaping quotes (#4666) 2019-04-19 13:55:20 -07:00
justinwyang
e88e706fcc Enforce quoting style in Travis. (#4589) 2019-04-11 14:24:26 -07:00
Eric Liang
f1239a7a63 Lint script link broken, also lint filter was broken for generated py files (#4133) 2019-02-22 17:33:08 -08:00
William Ma
c7a4c74f55 Moving tests from test/ to python/ray/tests/ (#3950) 2019-02-21 11:09:08 -08:00
Renamed from .travis/format.sh (Browse further)