Commit graph

10593 commits

Author SHA1 Message Date
Gagandeep Singh
33b4245df2
Fix race condition when starting redis (#19836)
Co-authored-by: Philipp Moritz <pcmoritz@gmail.com>
2021-11-17 17:43:35 -08:00
Simon Mo
c85e9e69b3
[Serve] Change multi_deployment_1k_noop_replica threshold (#20514) 2021-11-17 17:25:54 -08:00
Yi Cheng
cbf5826040
[workflow] Fix workflow event doc typo (#20465)
In the example, it says `after_checkpoint`, but this should be `event_checkpointed`
2021-11-17 16:18:20 -08:00
Amog Kamsetty
4cbcb11458
[Docker] Add commit as label (#20504)
Adds the Ray commit sha as a label for the docker image.
2021-11-17 15:20:41 -08:00
Richard Liaw
1cadd61917
Fix horovod failing tests by pinning down (#20484) 2021-11-17 13:54:25 -08:00
Sven Mika
56619b955e
[RLlib; Documentation] Some docstring cleanups; Rename RemoteVectorEnv into RemoteBaseEnv for clarity. (#20250) 2021-11-17 21:40:16 +01:00
gjoliver
724a140795
[rllib] Make sure json can serialize result dict (#20439)
We may have fields in the result dict that are or None.
Make sure our results are json serializable.
2021-11-17 10:27:00 -08:00
xwjiang2010
03aec4e04a
[Tune] Remove runner argument in start_trial. (#20464)
This internal legacy argument was not used by any code.
2021-11-17 16:59:57 +00:00
Alex Wu
d1c624901f
Add hiredis dependency on supported platforms (#20437)
<!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. -->

## Why are these changes needed?

This PR adds the hiredis dependency for non M1 machines. 

This removes the `redis < 4.0` pin.

Since hiredis doesn't have M1 mac wheels yet, so users there will have extra warning messages in their outputs if they use redis 4.0.
<!-- Please give a short summary of the change and the problem this solves. -->

## Related issue number

<!-- For example: "Closes #1234" -->

## Checks

- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
- [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(


Co-authored-by: Alex Wu <alex@anyscale.com>
2021-11-17 07:40:58 -08:00
Alex Wu
3d668768de
[docker] Upgrade numpy version (#20450)
<!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. -->

## Why are these changes needed?

The change in #20374 was interpreted as a file redirect, not a "greater than" by docker (strangely enough, differently than bash interprets it locally). 

<!-- Please give a short summary of the change and the problem this solves. -->

## Related issue number

<!-- For example: "Closes #1234" -->

## Checks

- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
- [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(


Co-authored-by: Alex <alex@anyscale.com>
2021-11-17 07:15:18 -08:00
Qing Wang
e01f14d7df
[DOC] Add namespace doc for Java part. (#20428)
Add namespace doc for Java part.
2021-11-17 23:02:47 +08:00
Devon Proctor
dba84546d9
[GCP] Filter GCP TPUs by cluster name, matching behavior for GCP compute nodes. (#20311)
Ray currently does not filter GCP TPU nodes based on the cluster name, resulting in conflicts when multiple ray clusters are running on the same GCP account.

This change updates the TPU behavior to match the GCP compute node behavior, i.e. filtering to TPU nodes for the current cluster.
2021-11-17 01:39:58 -08:00
Simon Mo
18d605fa7c
[Serve] Add experimental CLI for serve deploy (#20371) 2021-11-16 20:22:09 -08:00
Larry
454db6902c
[Java] Add timeout parameter for Ray.get() API (#20282)
Why are these changes needed?

Add timeout(ms) param for Java ray.get. The API changes have been updated to doc ([Ray Core Walkthrough]->[Fetching Results]).

eg:
ObjectRef<Integer> objRef = Ray.put(1);
objRef.get(1000) 
Ray.get(Ray.task(MyRayApp::slowFunction).remote(), 3000)

Related issue number
#20247
2021-11-17 11:02:17 +08:00
Simon Mo
2dc7a6c9f8
[CI] Pin manylinux image (#20451) 2021-11-16 17:52:51 -08:00
Antoni Baum
20fc9f907d
[CI] Fix tune dashboard, increase timeout for test_commands (#20453) 2021-11-16 17:52:17 -08:00
Avnish Narayan
dc17f0a241
Add error messages for missing tf and torch imports (#20205)
Co-authored-by: Sven Mika <sven@anyscale.io>
Co-authored-by: sven1977 <svenmika1977@gmail.com>
2021-11-16 16:30:53 -08:00
Simon Mo
5fccad4cc9
[Serve] Add experimental pipeline docs (#20292) 2021-11-16 16:13:55 -08:00
Simon Mo
32a4f48aa2
[CI] Don't test tune dashboard (#20452) 2021-11-16 15:07:56 -08:00
Richard Liaw
cf357f6bce
[docs] Add a talks section for ray.data (#20444) 2021-11-16 14:30:08 -08:00
Kai Fricke
05d21497db
[rllib/tune] Fix durable trainable in trainer template, add release test (#20422) 2021-11-16 20:52:42 +00:00
Edward Oakes
48b87d5830
[serve] Fix actor resources error in failure test (#20400) 2021-11-16 12:24:54 -08:00
Eric Liang
12a4489e30
Revert "[core] Nested task support via task depth + backpressure" (#20438)
Reverts ray-project/ray#17887

This causing several tests to be flaky (test_multinode_failures, test_virtual_actor, test_component_failures_2).
2021-11-16 11:14:45 -08:00
gjoliver
6e787f70e0
[Rllib/release] Disable throughput check (#20387)
Throughput check was enabled by d8a61f801f prematurely.
E.g., see state before the commit:
a931076f59/rllib/utils/test_utils.py (L740-L741)
2021-11-16 11:05:51 -08:00
Chen Shen
33c1ee0e86
[Core][actor out-of-order execution 5/n] implement out-of-order scheduling queue #20176
This PR belongs to the stack that enables out of order execution. Previous PR: #20160, Next PR: #20177

In this PR specifically, we implemented a simple out_of_order_scheduling queue which queues the task for execution as soon as the dependency is ready.
2021-11-16 10:53:51 -08:00
Chen Shen
f02b53a810
[Core][actor out-of-order execution 3/n] Introducing out-of-order actor submit queue (#20150)
Why are these changes needed?
This is the third PR in the stack that supports out or order execution for threaded/async actors. Previous PR #20149 Next PR #20160
At a high level, threaded actor/async actor already don't guarantee execution order, and the current "sequential" order implementation has caused some confusion and inconvenience. Please refer to #19822 for detailed discussion.

In this PR, we implemented the out-of-order of queue that supports out of order execution. Conceptually it's very simple: it sends the requests as soon as the dependency is resolved.
2021-11-16 10:48:49 -08:00
Simon Mo
5f2b035bba
Pin Redis version to < 4.0.0 (#20430)
<!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. -->

## Why are these changes needed?

This pin is needed to fix `test_output` on master, which broke when 4.0.0 was released. 

It may also fix the windows build (unsure). 

## Related issue number

<!-- For example: "Closes #1234" -->

## Checks

- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
- [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(
2021-11-16 10:48:36 -08:00
Alex Wu
8f21cdbddb
Revert "[dependencies] Use redis[hiredis] in setup.py" (#20435)
Reverts ray-project/ray#20423

`hiredis` will break our M1 support right now.
2021-11-16 10:46:22 -08:00
Kai Fricke
6ec256122c
[dependencies] Use redis[hiredis] in setup.py (#20423)
This is recommended by `redis-py` and as a side effect gets rid of a current error in `test_output` for the minimal dependency test (e.g. https://buildkite.com/ray-project/ray-builders-branch/builds/4746#7444b5d0-87c3-4998-b722-1cbc2d9fe7e3)
2021-11-16 10:25:36 -08:00
Amog Kamsetty
7e597814aa
[Release] Fix app config for horovod_tests (#20393)
Fixes `horovod_test` weekly test

Closes https://github.com/ray-project/ray/issues/20382
2021-11-16 09:06:42 -08:00
Antoni Baum
3f9ded55f7
[tune] Merge Analysis into ExperimentAnalysis (#20197)
Co-authored-by: Kai Fricke <kai@anyscale.com>
2021-11-16 16:47:12 +00:00
Antoni Baum
c097f64c79
[tune] Drop 0 value keys from PGF (#20279)
Co-authored-by: Kai Fricke <krfricke@users.noreply.github.com>
Co-authored-by: Kai Fricke <kai@anyscale.com>
2021-11-16 16:44:09 +00:00
Amog Kamsetty
4f88796d5a
[Train] Move to beta (#20378) 2021-11-16 08:19:30 -08:00
Simon Mo
ca90c63483
[Serve] Add serve failure test to CI (#20392) 2021-11-16 08:12:08 -08:00
Kai Fricke
693063d6f8
[ci/release] fix exit code (use value, not object) (#20427) 2021-11-16 15:15:39 +00:00
Kai Fricke
8a6c936aa8
[tune] Fix syncer=None not disabling trial-to-driver syncing (#20418) 2021-11-16 14:36:23 +00:00
Sven Mika
f82880eda1
Revert "Revert [RLlib] POC: Deprecate build_policy (policy template) for torch only; PPOTorchPolicy (#20061) (#20399)" (#20417)
This reverts commit 90dc5460d4.
2021-11-16 14:49:41 +01:00
Qing Wang
6504ad6bb2
[xlang] Add named actor xlang tests. (#20368)
We add named actor xlang tests, including both getting java named actor in python and get python named actor in Java.

Related issue number
#19794
2021-11-16 21:42:05 +08:00
SangBin Cho
5ec63ccc5f
[Regresion test] Placement group long running test (#20251)
Why are these changes needed?
In the past, there was a regression the placement group creation time gets slower as time goes. I believe the issue is fixed in the master, but this PR verifies if that's actually fixed.

This PR adds a long running test for the placement group. There are 2 purposes of the test.

Make sure the placement group creation / removal doesn't get slower as time goes. The test basically measure the first 20 iteration P50 creation time and run very long iteration. After all iteration, it checks if the p50 creation time is not too slow compared to the initial round.
Make sure placement group removal / creation works consistently for a long time without an issue.
Q: Should we make it a real long running test? (that runs for a day?)
2021-11-16 04:21:18 -08:00
SangBin Cho
137aec04c0
[Core] Better logs job message failure (#20363)
<!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. -->

## Why are these changes needed?

There's one user who has an issue that one of raylets cannot schedule tasks anymore because `num_worker_not_started_by_job_config_not_exist ` > 0.

This PR adds better log messages to figure out if the root cause is the job information is not properly propagated from GCS to raylet through Redis pubsub. 

## Related issue number

<!-- For example: "Closes #1234" -->

## Checks

- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
- [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(
2021-11-16 04:20:49 -08:00
Stefan Schneider
2b3d0c691f
[RLlib] Document and extend action mask example. (#20390)
Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
Co-authored-by: Sven Mika <sven@anyscale.io>
Co-authored-by: sven1977 <svenmika1977@gmail.com>
2021-11-16 13:20:41 +01:00
Kai Fricke
3e6ba5d6d2
Revert "Revert [RLlib] POC: PGTrainer class that works by sub-classing, not trainer_template.py." (#20285)
* Revert "Revert "[RLlib] POC: `PGTrainer` class that works by sub-classing, not `trainer_template.py`. (#20055)" (#20284)"
This reverts commit 246787cdd9.
Co-authored-by: sven1977 <svenmika1977@gmail.com>
2021-11-16 12:26:47 +01:00
Eric Liang
a1d78088e6
[Hotfix] Fix flaky test_basic_workflows_2
This test seems very flaky after the nested tasks PR merged. I think it's since the test is broken, and we made one of the branches more likely.
2021-11-16 01:11:36 -08:00
Yi Cheng
a4e187c0e7
[gcs] Update function table to use internal kv (#20152)
## Why are these changes needed?
This is a part of redis removal. This PR remove redis kv in function table. 
rpush related code is not updated in this PR.

## Related issue number
2021-11-15 23:34:41 -08:00
Eric Liang
460cf86858
Split blocks automatically into 500MB chunks on file read and transformation (#20235)
This PR adds support for automatic block splitting on read and map transforms, to keep block size bounded to ~500MiB. This avoids potential OOM situations where a map task may consume too much intermediate Python heap memory, or too much object store shared memory for one block.
2021-11-15 22:25:11 -08:00
Siyuan (Ryans) Zhuang
3e9cd4248e
[workflow] Refactoring workflow to make it easier to follow the logic (#20349)
* update

* cleanup
2021-11-15 21:02:33 -08:00
Yiran Wang
f4e8319eaa
Remove .boto files that are no longer needed during docker build (#20407)
## Why are these changes needed?

The .boto files are already added to the base image and ACL'ed to root, adding them again during app config build causes permission issues.

## Related issue number
2021-11-15 20:49:33 -08:00
Stephanie Wang
31eb385426
Revert "Revert "Revert "[core] Fail objects when pull/reconstruction hangs (#19789)" (#19904)" (#20120)" (#20406)
This reverts commit 0f57a9a105.
2021-11-15 20:36:22 -08:00
Alex Wu
75f421a3fd
[core] Nested task support via task depth + backpressure (#17887)
* needs depth

* depth

* .

* .

* .

* lint

* .

* lint

* fix tests

* .

* .

* .

* .

* cleanup

* .

* tests

* .

* more tests

* fix rest(?) of tests

* cleanup

* .

* .

* .

* .

* lint

* fix test basic

* fix ref counting?

* cleanup

* lint

* .

* pass dataset pipeline test

* .

* stephanie's comments + fix tests

* cleanup

* cleanup

* minor cleanup, then fix merge conflict

* lint

* cast

* feature flag

* lint

* lint

* refactor

* needs cleanup

* should pass

* lint

* .

* .

* .

* work?

* .

* works?

* lint

* work?

* .

* fix cpp tests

* .

* .

* split test

* fix windows?

* fix windows?

* fix test + check

* .

* all passing

* tests

* lint

* cleanup

* .

* most stephanie ocmments

* lint

* remove timer

* .

* allowed - capacity

* .

* everything except barrier

* addd guard

* works

* lint

* works?

* debug string

* last comment?

* short comments

* most comments

* lint

* done?

* done?

* .

* .

* .

* .

* done?

* done?

* update

* lint

* fix last test

* .

* .

* .

* .

* .

* .

* debug

* .

* .

* .

* .

* fix type

* .

* .

* cleanup

Co-authored-by: Alex Wu <alex@anyscale.com>
2021-11-15 17:39:50 -08:00
Edward Oakes
48bc1af2da
[job submission] Remove DOES_NOT_EXIST status (#20354) 2021-11-15 16:57:32 -08:00