Commit graph

73 commits

Author SHA1 Message Date
Guyang Song
419e78180a
[runtime env] plugin refactor[6/n]: java api refactor (#26783) 2022-07-26 09:00:57 +08:00
Jiajun Yao
53d878804a
[Core] Set c++ terminate handler to print stack trace (#26444) 2022-07-12 13:54:20 -07:00
clarng
922bd1ed69
Don't use local files / headers when using Bazel's sandboxed execution (#25752)
Why are these changes needed?

Wasn't able to build Ray following these instructions : https://docs.ray.io/en/latest/ray-contribute/development.html#building-ray

It fails to run
pip install -e . --verbose # Add --user if you see a permission denied error.

I have a local installation of protobuf via Homebrew and bazel is using its headers against the protobuf that it is pulling into its sandbox. It is a known issue with bazel and one of the workarounds is to block the local dir so it doesn't accidentally pick up the header if someone happens to have it installed locally.

Manually tested by running

bazel build --verbose_failures --sandbox_debug -- //:ray_pkg

Without the fix I would get an error similar to https://gist.github.com/clarng/ff7b7bf7672802d1e3e07b4b509e4fc8
With the fix it builds
2022-06-14 10:00:30 -07:00
Jiajun Yao
3fb63847e2
Show usage stats prompt (#23822)
Show usage stats prompt when it's enabled.

Current UX are:

* The usage stats enabled or disabled message is shown every time in both terminal and dashboard.
* If users don't explicitly enable or disable usage stats, the first time they start a ray cluster interactively, they will be asked to confirm and will enable if no user action within 10s. If it's non-interactive, collection is enabled by default without confirmation.
* ray.init() doesn't collect usage stats
* Usage stats can be disabled via three approaches: 1. RAY_USAGE_STATS_ENABLED env var, 2. ray xxx --disable-usage-stats, 3. ray disable-usage-stats
2022-04-25 16:01:24 -07:00
Kai Fricke
65d9a410f7
[ci] Clean up ci/ directory (refactor ci/travis) (#23866)
Clean up the ci/ directory. This means getting rid of the travis/ path completely and moving the files into sensible subdirectories.

Details:

- Moves everything under ci/travis into subdirectories, e.g. ci/build, ci/lint, etc.
- Minor adjustments to some scripts (variable renames)
- Removes the outdated (unused) asan tests
2022-04-13 18:11:30 +01:00
Kai Yang
041f98d5dd
Fix or remove unnecessary action_env settings in .bazelrc (#21307)
`PATH` is easy to be changed in a terminal session. Different `$PATH` values lead to miss of bazel cache. e.g. `pip install python -e` and `bazel build //:all` don't share cache because Python modifies `PATH`.

`LC_ALL`, `LANG`, and python-related environment variables are only used by C++ worker tests, which invokes the `ray start` command when running tests with `bazel test`. Java worker is not affected because we don't use `bazel test` to run Java tests. So these env variables should stay `test_env`, not `action_env`.

This PR can greatly improve the cache hit rate of Bazel build and test.
2022-03-15 12:13:13 +08:00
Stephanie Wang
cb218d03b9
[core] Enable lineage reconstruction by default (#22816)
Enables lineage reconstruction, which allows automatic recovery of task outputs, by default.

Also adds an info message to the driver whenever objects need to be reconstructed (not including recursive reconstruction).
2022-03-07 17:40:30 -05:00
Stephanie Wang
03a5589591
[core] Enable lineage reconstruction in CI (#21519)
Enables lineage reconstruction in all CI and release tests.
2022-02-18 11:04:20 -08:00
mwtian
1dd8b3d2bc
[Build] Remove debug info from Ray libraries. (#20389)
## Why are these changes needed?
Ray wheel size limit is still at 100MB. Removing debug symbols would decrease Ray Linux wheel sizes.

## Related issue number

## Checks
2021-11-15 16:40:48 -08:00
Eric Liang
9e448db731
[RFC] Add tsan build mode (#19971) 2021-11-02 22:29:51 -07:00
mwtian
d32facdef8
[Doc][Bazel] add comment to not use Bazel test result cache (#19842)
To avoid confusions in future, add a comment about why Ray is not using Bazel test result cache.
2021-10-29 16:46:22 -07:00
Simon Mo
5e927b01ad
Revert "[CI] Remove config that disables Bazel test result cache" (#19818)
* Revert "[CI] Remove config that disables Bazel test result cache (#18701)"

This reverts commit 098ff36faa.

* Remove all RLlib tests from BUILD that currently fail.

Co-authored-by: sven1977 <svenmika1977@gmail.com>
2021-10-28 15:54:53 +02:00
Eric Liang
10e27892c2
Suppress tsan false positive in gcs-pub-sub-test (#19727) 2021-10-25 19:52:53 -07:00
mwtian
098ff36faa
[CI] Remove config that disables Bazel test result cache (#18701) 2021-10-19 13:31:42 -07:00
Philipp Moritz
53f1d5de61
Fix C++17 support on some windows machines (#19088) 2021-10-05 15:15:59 -07:00
Yi Cheng
056c3af699
[core] Update placement group retry implementation (#18842)
* exp backoff

* up

* format

* up

* up

* up

* up

* up

* format

* fix

* up

* format

* adjust ordering

* up

* Revert "[tune] Cache unstaged placement groups for potential re-use (#18706)"

This reverts commit 2e99fb215f.

* up

* update

* format

* up

* format

* fix

* Revert "Revert "[tune] Cache unstaged placement groups for potential re-use (#18706)""

This reverts commit 93425fdb986059e53699623a0fc8590c062e139b.

* up

* format

* fix lint

* up

* up

* up

* up

* check

* add test1

* format

* up

* add test

* up

* up

* up

* fix

* up

* up

* up

* add test

* format

* up

* up

* fix lint

* format

* fix

* format

* fix

* up
2021-10-04 21:31:56 -07:00
Simon Mo
301312e77f
Fix windows build environment breakage (#19019) 2021-09-30 11:58:48 -07:00
mwtian
43ac18bbc0
[Build] include minimal debug info in C++ build; upgrade clang-format to 12 (#18888)
* Revert "Revert "[Build] include minimal debug info in C++ build; upgrade clang-format to 12 (#18840)" (#18886)"

This reverts commit f851a072f3.

* use gcc 8
2021-09-24 17:59:05 -07:00
Chen Shen
f851a072f3
Revert "[Build] include minimal debug info in C++ build; upgrade clang-format to 12 (#18840)" (#18886)
This reverts commit 07e1366383.
2021-09-24 12:55:08 -07:00
mwtian
07e1366383
[Build] include minimal debug info in C++ build; upgrade clang-format to 12 (#18840)
* debug info and clang-format

* doc

* fix

* no clang-format on all files

* gcc

* keep gcc 7
2021-09-24 12:26:33 -07:00
mwtian
efdbfcfdfb
[Build] Generate Bazel config for compiling with clang and libc++ in CI (#18622)
* Add Bazel config for building with llvm. Upgrade C++ std to 17.

* Fix redis. Try fixing asan and tsan

* Fix asan and format

* Update comments.

Co-authored-by: Chen Shen <scv119@gmail.com>
2021-09-17 19:01:07 -07:00
qicosmos
4af3d86d8a
Remove abi flag (#18538) 2021-09-17 12:13:56 +08:00
qicosmos
dd096c8e73
[C++ Worker]Fix abi issue (#18273) 2021-09-10 11:53:05 +08:00
SangBin Cho
688dbeb4cb
Revert "[cpp] Upgrade cpp from 14 -> 17 (#18455)" (#18480)
This reverts commit ccc16a46bb.
2021-09-09 16:47:19 -07:00
Chen Shen
5f57079041
use clang for C++ debug testing (#18343) 2021-09-09 15:48:36 -07:00
Yi Cheng
ccc16a46bb
[cpp] Upgrade cpp from 14 -> 17 (#18455) 2021-09-09 12:09:21 -07:00
Chen Shen
7e3e0d1535
[Test] Add C++ tsan test (#17875) 2021-08-24 00:57:32 -07:00
Chen Shen
880797d5c2
[Core][Test] Add ubsan support for C++ tests (#17812)
* support ubsan

* update
2021-08-17 10:22:03 -07:00
SangBin Cho
4971e13941
[Build] Asan wheel test (#17685)
* in progerss

* ASAN tests.

* d

* in progress

* in progress without the asan wheel

* Support the asan wheel.

* Support the asan wheels

* Not build a binary for asan

* Fix issues

* Remove a wrong build

* Separate out asan wheel build

* Try preparing more deps.

* ip

* Try different version

* done

* d

* Trial

* Another try

* Another try

* skip cpp build to see what happens

* add more des

* ip

* abc

* Try next

* completed

* try

* Try without static libasan

* dbg

* Try static link

* Fix issues

* abc
2021-08-17 10:21:41 -07:00
Chen Shen
0fd3f761b9
[ci][rfc] build debug wheels and run python test on debug build (#17399)
* enable debug mode

* add

* :upload debug wheels

* upload debug wheels

* add

* fix bug

* add dbg

* Update python/setup.py

Co-authored-by: Simon Mo <simon.mo@hey.com>

* skip windows

Co-authored-by: Simon Mo <simon.mo@hey.com>
2021-08-05 17:58:19 -07:00
Kai Fricke
1d52ab819f
[release] release 1.3.0 results and test updates (#15366)
Convert a number of release tests and add logs for release 1.3.0
2021-05-04 22:10:04 +01:00
Siyuan (Ryans) Zhuang
6f56d7e360
Fix compilation warnings (#15104) 2021-04-05 16:14:32 -07:00
Yi Cheng
ad8e35b919
[ray] Update cpp to std14 (#14441) 2021-03-10 14:05:52 -08:00
Clark Zinzow
17ae694405
Consolidate Bazel build and test action_env configs to prevent analysis cache discarding. (#14362) 2021-02-26 11:14:02 -08:00
Simon Mo
8b8d6b984b
[Buildkite] Add all Python tests (#13566) 2021-01-25 16:05:59 -08:00
Simon Mo
1e2adb335e
[CI] Buildkite PR Environment for Simple Tests (#13130) 2021-01-18 00:44:24 -08:00
Barak Michener
05c4e3fb2a
[build] Build wheels with manylinux2014 (#11621)
* necessary changes

* Split bazel install

* manylinux2014

* change references to manylinux2014

* Fix lint

* port alex's docker build changes

* fix config issue

* remove extra manylinux2010 requirement script

* revert SHA overwrite

* wip

* incompatible_linklibs

* fix nits
2020-11-03 19:36:32 -08:00
Eric Liang
c933477915
[new scheduler] Pass test_basic and add CI builds with flag on (#11635) 2020-10-28 11:02:43 -07:00
Akash Patel
91d0f41a2f
[CI] remove unsupported experimental_ui_deduplicate bazel flag (#11238) 2020-10-06 16:09:44 -07:00
SongGuyang
cb70864c04
[cpp worker] support cluster mode and object Put/Get works (#9682) 2020-08-28 13:53:36 +08:00
SangBin Cho
44826878ff
[Core] Remove Legacy Raylet Code (#9936)
* Remove a flag and some methods in node manager including HandleDisconnectedActor, ResubmitTask, and HandleTaskReconstruction

* Make actor creator always required + remove raylet transport

* Remove actor reporter + remove FinishAssignedActorCreationTask

* Remove actor tasks.

* Remove finishactortask and switched it to finishactorcreation task

* Remove reconstruction policy.

* Remove lineage cache.

* Formatting.

* Remove actor frontier code.

* Removed build error.

* Revert "Remove reconstruction policy."

This reverts commit 9d25c9bced4da5fbcac5d484d51013345f16513b.

* Recover HandleReconstruction to mark expired objects as failed.
2020-08-06 16:37:50 -07:00
mehrdadn
e2c0174ab2
Factor out some Bazel options into .bazelrc (#9804)
* Factor out --keep_going in Bazel --config=ci

* Remove Bazel --test_timeout=600 for Windows

* Use global --test_output for Bazel CI

Co-authored-by: Mehrdad <noreply@github.com>
2020-07-30 18:09:31 -07:00
SangBin Cho
2f674728a6
[GCS Actor Management] Gcs actor management broken detached actor (#9473) 2020-07-16 15:41:18 +08:00
mehrdadn
aa8928fac2
Make more tests compatible with Windows (#9303) 2020-07-15 11:34:33 -05:00
mehrdadn
3d65682e62
Bazel selects compiler flags based on compiler (#9313)
Co-authored-by: Mehrdad <noreply@github.com>
2020-07-13 15:31:46 -07:00
Ruifang Chen
c37d30a079
Remove unnecessary asan config (#9350)
Co-authored-by: ruifang.crf <ruifang.crf@alibaba-inc.com>
2020-07-09 14:50:54 +08:00
mehrdadn
29acf272b7
Build with Visual C++ (#9190)
Co-authored-by: Mehrdad <noreply@github.com>
Co-authored-by: Simon Mo <xmo@berkeley.edu>
2020-07-02 09:34:24 -07:00
mehrdadn
98d68b31c3
Suppress GRPC SO_REUSADDR warning on Linux (#7972)
Co-authored-by: Mehrdad <noreply@github.com>
2020-06-23 21:58:43 -07:00
mehrdadn
4afa2b304a
Clean up CI ASAN & .bazelrc (#8828) 2020-06-15 17:27:17 -07:00
mehrdadn
67cd9a0c95
CI fixes and improvements (#8849)
Co-authored-by: Mehrdad <noreply@github.com>
2020-06-09 14:07:54 -07:00