hiro/ray
1
0
Fork 0
mirror of https://github.com/vale981/ray synced 2025-03-06 02:21:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

[Train] Monkeypatch environment variables in test_json (#21260)

Browse source 
If we use `os.environ` to set environment variables in tests, then our tests become coupled. By using `monkeypatch`, we can safely set environment variables while ensuring our tests remain decoupled. 

For more information, see the [monkeypatching documentation](https://docs.pytest.org/en/6.2.x/monkeypatch.html#monkeypatching-environment-variables).
This commit is contained in:
Balaji Veeramani 2022-01-03 11:12:44 -06:00 • committed by GitHub
parent 7ce22b72ed
commit fa4e41c5b2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
python/ray/train/tests/test_callbacks.py
View file

@ -59,10 +59,10 @@ class TestBackend(Backend):
@pytest.mark.parametrize("workers_to_log", [0, None, [0, 1]])
@pytest.mark.parametrize("detailed", [False, True])
@pytest.mark.parametrize("filename", [None, "my_own_filename.json"])
def test_json(ray_start_4_cpus, make_temp_dir, workers_to_log, detailed,
filename):
def test_json(monkeypatch, ray_start_4_cpus, make_temp_dir, workers_to_log,
detailed, filename):
if detailed:
os.environ[ENABLE_DETAILED_AUTOFILLED_METRICS_ENV] = "1"
monkeypatch.setenv(ENABLE_DETAILED_AUTOFILLED_METRICS_ENV, "1")
config = TestConfig()
@ -119,9 +119,6 @@ def test_json(ray_start_4_cpus, make_temp_dir, workers_to_log, detailed,
all(not any(key in worker for key in DETAILED_AUTOFILLED_KEYS)
for worker in element) for element in log)
os.environ.pop(ENABLE_DETAILED_AUTOFILLED_METRICS_ENV, 0)
assert ENABLE_DETAILED_AUTOFILLED_METRICS_ENV not in os.environ
def _validate_tbx_result(events_dir):
events_file = list(glob.glob(f"{events_dir}/events*"))[0]