hiro/ray
1
0
Fork 0
mirror of https://github.com/vale981/ray synced 2025-03-06 02:21:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Raise error if space in redis password (#5673)

Browse source
This commit is contained in:
Edward Oakes 2019-09-11 20:58:39 -07:00 • committed by Philipp Moritz
parent 0bf79cfbde
commit ee5db5b67f
2 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
doc/source/configure.rst
View file

@ -116,6 +116,9 @@ behind a firewall, this feature is useful for instances exposed to the internet
where configuring a firewall is not possible. Because Redis is where configuring a firewall is not possible. Because Redis is
very fast at serving queries, the chosen password should be long. very fast at serving queries, the chosen password should be long.
.. note:: The Redis passwords provided below may not contain spaces.
Redis authentication is only supported on the raylet code path. Redis authentication is only supported on the raylet code path.
To add authentication via the Python API, start Ray using: To add authentication via the Python API, start Ray using:

2
python/ray/services.py
View file

@ -772,6 +772,8 @@ def _start_redis_instance(executable,
# Construct the command to start the Redis server. # Construct the command to start the Redis server.
command = [executable] command = [executable]
if password: if password:
if " " in password:
raise ValueError("Spaces not permitted in redis password.")
command += ["--requirepass", password] command += ["--requirepass", password]
command += ( command += (
["--port", str(port), "--loglevel", "warning"] + load_module_args) ["--port", str(port), "--loglevel", "warning"] + load_module_args)