hiro/ray
1
0
Fork 0
mirror of https://github.com/vale981/ray synced 2025-03-06 02:21:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

[Core] Stop reporting tasks spec to GCS that are unnecessary #19699 (#19699)

Browse source 
This RPC is from legacy code and not needed anymore (the task spec is already in the actor table), but it adds quite amount of keys to Redis.

The below is the sum of bytes size(? I am not sure if it is bytes size, but I grabbed the length of the value when I queried Redis) of each prefix when running many_ppo. As you can see Task& and Task takes a lot of part although they are not really used.

�[0m ��[12A�[9C�[?7h�[0m�[?12l�[?25h�[?25l�[?7l�[0mb�[?7h�[0m�[?12l�[?25h�[?25l�[?7l�[10D�[0m�[J�[0;38;5;28mIn [�[0;92;1m82�[0;38;5;28m]: �[0mb�[10D�[0m

�[J�[?7h�[0m�[?12l�[?25h�[?2004l�[0m�[?7h�[0;38;5;88mOut[�[0;91;1m82�[0;38;5;88m]: �[0m�[0m
defaultdict(int,
            {b'WORKE': 1080864,
             b'ACTOR': 1470931,
             b'TASK&': 1020646,
             b'TASK:': 870551,
             b'PROFI': 360000,
             b'PLACE': 10107,
             b'JOB:\x01': 8,
             b'JOB:\x04': 8,
             b'NODE:': 99,
             b'NODE_': 126,
             b'INTER': 44,
             b'JOB:\x03': 8,
             b'redis': 16,
             b'JOB:\x02': 8,
             b'JOB:\x05': 8})
This commit is contained in:
SangBin Cho 2021-10-26 20:17:58 +09:00 • committed by GitHub
parent 98244ad130
commit e914ea930d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/ray/raylet/node_manager.cc
View file

@ -1552,13 +1552,6 @@ void NodeManager::HandleRequestWorkerLease(const rpc::RequestWorkerLeaseRequest
if (is_actor_creation_task) {
actor_id = task.GetTaskSpecification().ActorCreationId();
// Save the actor creation task spec to GCS, which is needed to
// reconstruct the actor when raylet detect it dies.
std::shared_ptr<rpc::TaskTableData> data = std::make_shared<rpc::TaskTableData>();
data->mutable_task()->mutable_task_spec()->CopyFrom(
task.GetTaskSpecification().GetMessage());
RAY_CHECK_OK(gcs_client_->Tasks().AsyncAdd(data, nullptr));
}
if (RayConfig::instance().enable_worker_prestart()) {