From e24c1dccb08f520c3d345788550cc4f6bef53c44 Mon Sep 17 00:00:00 2001
From: xwjiang2010 <87673679+xwjiang2010@users.noreply.github.com>
Date: Tue, 23 Nov 2021 08:53:28 -0800
Subject: [PATCH] [Tune] Remove unnecessary argument in `update_last_result`.
 (#20653)

---
 python/ray/tune/trial.py        | 2 +-
 python/ray/tune/trial_runner.py | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/python/ray/tune/trial.py b/python/ray/tune/trial.py
index 842512847..6cf88186d 100644
--- a/python/ray/tune/trial.py
+++ b/python/ray/tune/trial.py
@@ -627,7 +627,7 @@ class Trial:
         """
         return self.num_failures < self.max_failures or self.max_failures < 0
 
-    def update_last_result(self, result, terminate=False):
+    def update_last_result(self, result):
         if self.experiment_tag:
             result.update(experiment_tag=self.experiment_tag)
 
diff --git a/python/ray/tune/trial_runner.py b/python/ray/tune/trial_runner.py
index dea86ca45..fdfeceebd 100644
--- a/python/ray/tune/trial_runner.py
+++ b/python/ray/tune/trial_runner.py
@@ -1023,8 +1023,7 @@ class TrialRunner:
                         trial=trial)
 
         if not is_duplicate:
-            trial.update_last_result(
-                result, terminate=(decision == TrialScheduler.STOP))
+            trial.update_last_result(result)
 
         # Checkpoints to disk. This should be checked even if
         # the scheduler decision is STOP or PAUSE. Note that
@@ -1357,7 +1356,7 @@ class TrialRunner:
             try:
                 results = self.trial_executor.fetch_result(trial)
                 result = results[-1]
-                trial.update_last_result(result, terminate=True)
+                trial.update_last_result(result)
                 self._scheduler_alg.on_trial_complete(self, trial, result)
                 self._search_alg.on_trial_complete(
                     trial.trial_id, result=result)