From a776209aec95b22d28d89a7f036af1a093b87752 Mon Sep 17 00:00:00 2001 From: Stephanie Wang Date: Wed, 9 Dec 2020 17:20:38 -0500 Subject: [PATCH] Revert "Fix dashboard agent check ppid is raylet pid (#12256)" (#12729) This reverts commit 3ce92869778ecb20375785beeb6e85dda9ab7821. --- dashboard/agent.py | 5 +---- dashboard/tests/test_dashboard.py | 5 ----- src/ray/raylet/agent_manager.cc | 2 -- 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/dashboard/agent.py b/dashboard/agent.py index ef146e129..676312245 100644 --- a/dashboard/agent.py +++ b/dashboard/agent.py @@ -91,12 +91,9 @@ class DashboardAgent(object): async def _check_parent(): """Check if raylet is dead.""" curr_proc = psutil.Process() - ppid = int(os.environ["RAY_NODE_PID"]) - logger.info("Parent pid is %s", ppid) while True: parent = curr_proc.parent() - if parent is None or parent.pid == 1 or (ppid and - ppid != parent.pid): + if parent is None or parent.pid == 1: logger.error("raylet is dead, agent will die because " "it fate-shares with raylet.") sys.exit(0) diff --git a/dashboard/tests/test_dashboard.py b/dashboard/tests/test_dashboard.py index 1b9f82120..a37fd3012 100644 --- a/dashboard/tests/test_dashboard.py +++ b/dashboard/tests/test_dashboard.py @@ -137,11 +137,6 @@ def test_basic(ray_start_with_dashboard): assert agent_proc.pid == agent_pid time.sleep(1) - # The agent should be dead if raylet exits. - raylet_proc.kill() - raylet_proc.wait() - agent_proc.wait(5) - # Check redis keys are set. logger.info("Check redis keys are set.") dashboard_address = client.get(dashboard_consts.REDIS_KEY_DASHBOARD) diff --git a/src/ray/raylet/agent_manager.cc b/src/ray/raylet/agent_manager.cc index ef9d8c45d..23b8769c8 100644 --- a/src/ray/raylet/agent_manager.cc +++ b/src/ray/raylet/agent_manager.cc @@ -58,10 +58,8 @@ void AgentManager::StartAgent() { } argv.push_back(NULL); // Set node id to agent. - static std::string pid_string = std::to_string(getpid()); ProcessEnvironment env; env.insert({"RAY_NODE_ID", options_.node_id.Hex()}); - env.insert({"RAY_NODE_PID", pid_string}); Process child(argv.data(), nullptr, ec, false, env); if (!child.IsValid() || ec) { // The worker failed to start. This is a fatal error.