hiro/ray
1
0
Fork 0
mirror of https://github.com/vale981/ray synced 2025-03-06 02:21:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix create actor rpc reconnect bug (#8855)

Browse source
This commit is contained in:
fangfengbin 2020-06-10 10:53:53 +08:00 • committed by GitHub
parent 4bda333412
commit a5bebd4408
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
python/ray/tests/test_gcs_fault_tolerance.py
View file

@ -1,5 +1,4 @@
import sys import sys
import time
import ray import ray
@ -23,11 +22,6 @@ def test_gcs_server_restart():
ray.worker._global_node.kill_gcs_server() ray.worker._global_node.kill_gcs_server()
ray.worker._global_node.start_gcs_server() ray.worker._global_node.start_gcs_server()
# TODO(ffbin): After gcs server restarts, if an RPC request is sent to
# gcs server immediately, gcs server cannot receive the request,
# but the request will return success. We will fix this in the next pr.
time.sleep(1)
result = ray.get(actor1.method.remote(7)) result = ray.get(actor1.method.remote(7))
assert result == 9 assert result == 9

2
src/ray/rpc/gcs_server/gcs_rpc_client.h
View file

@ -105,7 +105,7 @@ class GcsRpcClient {
VOID_GCS_RPC_CLIENT_METHOD(JobInfoGcsService, GetAllJobInfo, job_info_grpc_client_, ) VOID_GCS_RPC_CLIENT_METHOD(JobInfoGcsService, GetAllJobInfo, job_info_grpc_client_, )
/// Create actor via GCS Service. /// Create actor via GCS Service.
VOID_RPC_CLIENT_METHOD(ActorInfoGcsService, CreateActor, actor_info_grpc_client_, ) VOID_GCS_RPC_CLIENT_METHOD(ActorInfoGcsService, CreateActor, actor_info_grpc_client_, )
/// Get actor data from GCS Service. /// Get actor data from GCS Service.
VOID_GCS_RPC_CLIENT_METHOD(ActorInfoGcsService, GetActorInfo, actor_info_grpc_client_, ) VOID_GCS_RPC_CLIENT_METHOD(ActorInfoGcsService, GetActorInfo, actor_info_grpc_client_, )