From 9973a6e37c3887f399892f6de5f5b132da87fa8c Mon Sep 17 00:00:00 2001 From: Philipp Moritz Date: Fri, 17 Feb 2017 23:35:41 -0800 Subject: [PATCH] fix bug in numbuf serialization (#296) --- src/numbuf/python/src/pynumbuf/adapters/python.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/numbuf/python/src/pynumbuf/adapters/python.cc b/src/numbuf/python/src/pynumbuf/adapters/python.cc index 0e98f07d8..6cf88bf8c 100644 --- a/src/numbuf/python/src/pynumbuf/adapters/python.cc +++ b/src/numbuf/python/src/pynumbuf/adapters/python.cc @@ -98,13 +98,14 @@ Status append(PyObject* elem, SequenceBuilder& builder, std::vector& Py_ssize_t size; #if PY_MAJOR_VERSION >= 3 char* data = PyUnicode_AsUTF8AndSize(elem, &size); + Status s = builder.AppendString(data, size); #else PyObject* str = PyUnicode_AsUTF8String(elem); char* data = PyString_AS_STRING(str); size = PyString_GET_SIZE(str); + Status s = builder.AppendString(data, size); Py_XDECREF(str); #endif - Status s = builder.AppendString(data, size); RETURN_NOT_OK(s); } else if (PyList_Check(elem)) { builder.AppendList(PyList_Size(elem));