hiro/ray
1
0
Fork 0
mirror of https://github.com/vale981/ray synced 2025-03-08 19:41:38 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Disable port sharing in grpc server (#6479)

Browse source
This commit is contained in:
Kai Yang 2019-12-18 14:48:54 +08:00 • committed by Hao Chen
parent 7e6defca72
commit 978d72be0a
1 changed files with 10 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
src/ray/rpc/grpc_server.cc
View file

@ -3,20 +3,6 @@
#include <grpcpp/impl/service_type.h> #include <grpcpp/impl/service_type.h>
#include <boost/asio/detail/socket_holder.hpp> #include <boost/asio/detail/socket_holder.hpp>
namespace {
bool PortNotInUse(int port) {
boost::asio::detail::socket_holder fd(socket(AF_INET, SOCK_STREAM, 0));
struct sockaddr_in server_addr = {0};
server_addr.sin_family = AF_INET;
server_addr.sin_addr.s_addr = htonl(INADDR_ANY);
server_addr.sin_port = htons(port);
return fd.get() >= 0 &&
bind(fd.get(), (struct sockaddr *)&server_addr, sizeof(server_addr)) == 0;
}
} // namespace
namespace ray { namespace ray {
namespace rpc { namespace rpc {
@ -26,18 +12,14 @@ GrpcServer::GrpcServer(std::string name, const uint32_t port, int num_threads)
} }
void GrpcServer::Run() { void GrpcServer::Run() {
uint32_t specified_port = port_;
std::string server_address("0.0.0.0:" + std::to_string(port_)); std::string server_address("0.0.0.0:" + std::to_string(port_));
// Unfortunately, grpc will not return an error if the specified port is in
// use. There is a race condition here where two servers could check the same
// port, but only one would succeed in binding.
if (port_ > 0) {
RAY_CHECK(PortNotInUse(port_))
<< "Port " << port_
<< " specified by caller already in use. Try passing node_manager_port=... into "
"ray.init() to pick a specific port";
}
grpc::ServerBuilder builder; grpc::ServerBuilder builder;
// Disable the SO_REUSEPORT option. We don't need it in ray. If the option is enabled
// (default behavior in grpc), we may see multiple workers listen on the same port and
// the requests sent to this port may be handled by any of the workers.
builder.AddChannelArgument(GRPC_ARG_ALLOW_REUSEPORT, 0);
// TODO(hchen): Add options for authentication. // TODO(hchen): Add options for authentication.
builder.AddListeningPort(server_address, grpc::InsecureServerCredentials(), &port_); builder.AddListeningPort(server_address, grpc::InsecureServerCredentials(), &port_);
// Register all the services to this server. // Register all the services to this server.
@ -54,6 +36,11 @@ void GrpcServer::Run() {
} }
// Build and start server. // Build and start server.
server_ = builder.BuildAndStart(); server_ = builder.BuildAndStart();
// If the grpc server failed to bind the port, the `port_` will be set to 0.
RAY_CHECK(port_ > 0)
<< "Port " << specified_port
<< " specified by caller already in use. Try passing node_manager_port=... into "
"ray.init() to pick a specific port";
RAY_LOG(INFO) << name_ << " server started, listening on port " << port_ << "."; RAY_LOG(INFO) << name_ << " server started, listening on port " << port_ << ".";
// Create calls for all the server call factories. // Create calls for all the server call factories.