hiro/ray
1
0
Fork 0
mirror of https://github.com/vale981/ray synced 2025-03-05 10:01:43 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Added retry logic in test_basic::test_ray_options (#19832)

Browse source 
* Added retry logic in test_ray_options

* Applied linting format

* Made test consistent
This commit is contained in:
Gagandeep Singh 2021-10-29 22:45:12 +05:30 • committed by GitHub
parent fdefd875c3
commit 9460a5375b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 30 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
python/ray/tests/test_basic.py
View file

@ -303,27 +303,44 @@ def test_ray_options(shutdown_only):
@ray.remote(
num_cpus=2, num_gpus=3, memory=150 * 2**20, resources={"custom1": 1})
def foo():
import time
# Sleep for a heartbeat period to ensure resources changing reported.
time.sleep(0.1)
return ray.available_resources()
def foo(expected_resources):
# Possibly wait until the available resources have been updated
# (there might be a delay due to heartbeats)
retries = 10
keys = ["CPU", "GPU", "custom1"]
while retries >= 0:
resources = ray.available_resources()
do_return = True
for key in keys:
if resources[key] != expected_resources[key]:
print(key, resources[key], expected_resources[key])
do_return = False
break
if do_return:
return resources["memory"]
time.sleep(0.1)
retries -= 1
raise RuntimeError("Number of retries exceeded")
without_options = ray.get(foo.remote())
with_options = ray.get(
expected_resources_without_options = {
"CPU": 8.0,
"GPU": 7.0,
"custom1": 1.0
}
memory_available_without_options = ray.get(
foo.remote(expected_resources_without_options))
expected_resources_with_options = {"CPU": 7.0, "GPU": 6.0, "custom1": 1.5}
memory_available_with_options = ray.get(
foo.options(
num_cpus=3,
num_gpus=4,
memory=50 * 2**20,
resources={
"custom1": 0.5
}).remote())
}).remote(expected_resources_with_options))
to_check = ["CPU", "GPU", "memory", "custom1"]
for key in to_check:
print(key, without_options[key], with_options[key])
assert without_options[key] != with_options[key], key
assert without_options != with_options
assert memory_available_without_options < memory_available_with_options
@pytest.mark.skipif(client_test_enabled(), reason="internal api")