hiro/ray
1
0
Fork 0
mirror of https://github.com/vale981/ray synced 2025-03-05 18:11:42 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

[ci/repro] Add SYS_PTRACE to docker container, use unique name (#21377)

Browse source 
This will start repro docker containers with SYS_PTRACE capabilities to enable debugging e.g. via py-spy.
Additionally, default instance name tags for instance re-use will be generated using the buildkite build id and job id.
This commit is contained in:
Kai Fricke 2022-01-04 16:59:12 +00:00 • committed by GitHub
parent 5aa00ba5eb
commit 94242e3e6e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
ci/repro-ci.py
View file

@ -103,7 +103,7 @@ class ReproSession:
def __init__(self,
buildkite_token: str,
instance_name: str = "repro-ci-dev",
instance_name: Optional[str] = None,
logger: Optional[logging.Logger] = None):
self.logger = logger or logging.getLogger(self.__class__.__name__)
@ -165,6 +165,12 @@ class ReproSession:
def aws_start_instance(self):
assert self.env
if not self.aws_instance_name:
self.aws_instance_name = (
f"repro_ci_{self.build_id}_{self.job_id[:8]}")
self.logger.info(
f"No instance name provided, using {self.aws_instance_name}")
instance_type = self.env["BUILDKITE_AGENT_META_DATA_AWS_INSTANCE_TYPE"]
instance_ami = self.env["BUILDKITE_AGENT_META_DATA_AWS_AMI_ID"]
instance_sg = "sg-0ccfca2ef191c04ae"
@ -546,11 +552,11 @@ class ReproSession:
@click.command()
@click.argument("session_url", required=False)
@click.option("-n", "--instance-name", default="repro-ci-dev")
@click.option("-n", "--instance-name", default=None)
@click.option("-c", "--commands", is_flag=True, default=False)
@click.option("-f", "--filters", multiple=True, default=[])
def main(session_url: Optional[str],
instance_name: str = "repro-ci-dev",
instance_name: Optional[str] = None,
commands: bool = False,
filters: Optional[List[str]] = None):
random.seed(1235)
@ -606,7 +612,10 @@ def main(session_url: Optional[str],
},
script_command=("sed -E 's/"
"docker run/"
"docker run --name ray_container -d/g' | "
"docker run "
"--cap-add=SYS_PTRACE "
"--name ray_container "
"-d/g' | "
"bash -l"))
repro.create_new_ssh_client()
@ -619,6 +628,14 @@ def main(session_url: Optional[str],
repro.print_buildkite_command(skipped=True)
repro.transfer_env_to_container()
# Print once more before attaching
click.secho("Instance ID: ", nl=False)
click.secho(repro.aws_instance_id, bold=True)
click.secho("Instance IP: ", nl=False)
click.secho(repro.aws_instance_ip, bold=True)
print("-" * 80)
repro.attach_to_container()
logger.info("You are now detached from the AWS instance.")