[Core] Use node ip address properly in ray.init (#10829)

* Fix.

* Addressed code review.

* Addressed code review.
This commit is contained in:
SangBin Cho 2020-09-24 11:44:52 -07:00 committed by GitHub
parent 4ac58d54d6
commit 8c241d5f1d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 4 deletions

View file

@ -104,6 +104,7 @@ class Node:
head), "LRU Evict can only be passed into the head node."
self._raylet_ip_address = raylet_ip_address
self.metrics_agent_port = (ray_params.metrics_agent_port
or self._get_unused_port()[0])
self._metrics_export_port = ray_params.metrics_export_port

View file

@ -625,6 +625,11 @@ def init(
"please call ray.init() or ray.init(address=\"auto\") on the "
"driver.")
# Convert hostnames to numerical IP address.
if _node_ip_address is not None:
node_ip_address = services.address_to_ip(_node_ip_address)
raylet_ip_address = node_ip_address
if address:
redis_address, _, _ = services.validate_redis_address(address)
else:
@ -662,8 +667,8 @@ def init(
# In this case, we need to start a new cluster.
ray_params = ray.parameter.RayParams(
redis_address=redis_address,
node_ip_address=None,
raylet_ip_address=None,
node_ip_address=node_ip_address,
raylet_ip_address=raylet_ip_address,
object_ref_seed=None,
driver_mode=driver_mode,
redirect_worker_output=None,
@ -727,8 +732,8 @@ def init(
# In this case, we only need to connect the node.
ray_params = ray.parameter.RayParams(
node_ip_address=None,
raylet_ip_address=None,
node_ip_address=node_ip_address,
raylet_ip_address=raylet_ip_address,
redis_address=redis_address,
redis_password=_redis_password,
object_ref_seed=None,