hiro/ray
1
0
Fork 0
mirror of https://github.com/vale981/ray synced 2025-03-06 10:31:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix passing env on windows (#13253)

Browse source
This commit is contained in:
fyrestone 2021-01-20 00:04:38 +08:00 • committed by GitHub
parent 2e3655e8a9
commit 86d5000047
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/ray/util/process.cc
View file

@ -139,6 +139,15 @@ class ProcessFD {
STARTUPINFO si = {sizeof(si)};
RAY_UNUSED(
new_env_block.c_str()); // Ensure there's a final terminator for Windows
// MSDN:
// https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createprocessa
// Note that an ANSI environment block is terminated by two zero bytes:
// one for the last string, one more to terminate the block.
// A Unicode environment block is terminated by four zero bytes:
// two for the last string, two more to terminate the block.
if (!new_env_block.empty()) {
new_env_block += '\0';
}
char *const envp = &new_env_block[0];
if (CreateProcessA(NULL, cmdline, NULL, NULL, FALSE, 0, envp, NULL, &si, &pi)) {
succeeded = true;