hiro/ray
1
0
Fork 0
mirror of https://github.com/vale981/ray synced 2025-03-06 10:31:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

[RLlib] Fix seeding issue (#10589)

Browse source
This commit is contained in:
architkulkarni 2020-09-04 17:17:53 -07:00 • committed by GitHub
parent 34bda32054
commit 6ae9e76b81
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
rllib/evaluation/rollout_worker.py
View file

@ -388,9 +388,10 @@ class RolloutWorker(ParallelIteratorWorker):
np.random.seed(seed)
random.seed(seed)
if not hasattr(self.env, "seed"):
raise ValueError("Env doesn't support env.seed(): {}".format(
logger.info("Env doesn't support env.seed(): {}".format(
self.env))
self.env.seed(seed)
else:
self.env.seed(seed)
try:
assert torch is not None
torch.manual_seed(seed)

8
rllib/tests/test_rollout_worker.py
View file

@ -626,6 +626,14 @@ class TestRolloutWorker(unittest.TestCase):
del os.environ["env_key_1"]
del os.environ["env_key_2"]
def test_no_env_seed(self):
ev = RolloutWorker(
env_creator=lambda _: MockVectorEnv(episode_length=20, num_envs=8),
policy=MockPolicy,
seed=1)
assert not hasattr(ev.env, "seed")
ev.stop()
def sample_and_flush(self, ev):
time.sleep(2)
ev.sample()