hiro/ray
1
0
Fork 0
mirror of https://github.com/vale981/ray synced 2025-03-06 02:21:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix heap-use-after-free bug of gcs pub sub testcase (#8968)

Browse source
This commit is contained in:
fangfengbin 2020-06-16 21:00:37 +08:00 • committed by GitHub
parent b68fede30b
commit 4facac023f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/ray/gcs/pubsub/test/gcs_pub_sub_test.cc
View file

@ -45,9 +45,13 @@ class GcsPubSubTest : public ::testing::Test {
pub_sub_.reset(); pub_sub_.reset();
client_->Disconnect(); client_->Disconnect();
io_service_.stop(); io_service_.stop();
client_.reset();
thread_io_service_->join(); thread_io_service_->join();
thread_io_service_.reset(); thread_io_service_.reset();
// Note: If we immediately reset client_ after io_service_ stop, because client_ still
// has thread executing logic, such as unsubscribe's callback, the problem of heap
// used after free will occur.
client_.reset();
} }
void Subscribe(const std::string &channel, const std::string &id, void Subscribe(const std::string &channel, const std::string &id,