hiro/ray
1
0
Fork 0
mirror of https://github.com/vale981/ray synced 2025-03-05 10:01:43 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix logger initialization (#27238)

Browse source
This commit is contained in:
Eric Liang 2022-07-29 10:55:15 -07:00 • committed by GitHub
parent 545c51609f
commit 467430dd55
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
python/ray/_private/worker.py
View file

@ -1165,7 +1165,7 @@ def init(
arguments is passed in.
"""
if configure_logging:
setup_logger(logging_level, logging_format)
setup_logger(logging_level, logging_format or ray_constants.LOGGER_FORMAT)
# Parse the hidden options:
_enable_object_reconstruction: bool = kwargs.pop(
@ -1192,8 +1192,6 @@ def init(
_node_name: str = kwargs.pop("_node_name", None)
# Fix for https://github.com/ray-project/ray/issues/26729
_skip_env_hook: bool = kwargs.pop("_skip_env_hook", False)
if not logging_format:
logging_format = ray_constants.LOGGER_FORMAT
# If available, use RAY_ADDRESS to override if the address was left
# unspecified, or set to "auto" in the call to init

15
python/ray/tests/test_output.py
View file

@ -14,6 +14,21 @@ from ray._private.test_utils import (
)
def test_logger_config():
script = """
import ray
ray.init(num_cpus=1)
"""
proc = run_string_as_driver_nonblocking(script)
out_str = proc.stdout.read().decode("ascii")
err_str = proc.stderr.read().decode("ascii")
print(out_str, err_str)
assert "INFO worker.py:" in err_str, err_str
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_spill_logs():
script = """