hiro/ray
1
0
Fork 0
mirror of https://github.com/vale981/ray synced 2025-03-06 02:21:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

[tune] Avoid looping through _live_trials twice in _get_next_trial. (#19596)

Browse source
This commit is contained in:
xwjiang2010 2021-10-25 11:26:55 -07:00 • committed by GitHub
parent b65aca9002
commit 46266b15f0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
python/ray/tune/trial_runner.py
View file

@ -812,11 +812,19 @@ class TrialRunner:
Blocks if all trials queued have finished, but search algorithm is
still not finished.
"""
trials_done = all(trial.is_finished() for trial in self._live_trials)
wait_for_trial = trials_done and not self._search_alg.is_finished()
no_trials_unfinished = True
no_trials_pending = True
for trial in self._live_trials:
if not trial.is_finished():
no_trials_unfinished = False
if trial.status == Trial.PENDING:
no_trials_pending = False
if not no_trials_unfinished and not no_trials_pending:
break
wait_for_trial = (no_trials_unfinished
and not self._search_alg.is_finished())
# Only fetch a new trial if we have no pending trial
if not any(trial.status == Trial.PENDING
for trial in self._live_trials) or wait_for_trial:
if wait_for_trial or no_trials_pending:
self._update_trial_queue(blocking=wait_for_trial)
with warn_if_slow("choose_trial_to_run"):
trial = self._scheduler_alg.choose_trial_to_run(self)