Revert "WINDOWS: unskip passing runtime_env tests (#21252)" (#21352)

This reverts commit fcb952e1bc.
This commit is contained in:
Archit Kulkarni 2022-01-03 11:07:17 -08:00 committed by GitHub
parent 43a9e95dc0
commit 4581baa7dc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 22 deletions

View file

@ -165,6 +165,8 @@ test_python() {
-python/ray/tests:test_ray_init # test_redis_port() seems to fail here, but pass in isolation
-python/ray/tests:test_resource_demand_scheduler
-python/ray/tests:test_reference_counting # too flaky 9/25/21
-python/ray/tests:test_runtime_env_plugin # runtime_env not supported on Windows
-python/ray/tests:test_runtime_env_env_vars # runtime_env not supported on Windows
-python/ray/tests:test_runtime_env_complicated # conda install slow leading to timeout
-python/ray/tests:test_stress # timeout
-python/ray/tests:test_stress_sharded # timeout

View file

@ -43,6 +43,8 @@ def test_get_release_wheel_url():
assert requests.head(url).status_code == 200, url
@pytest.mark.skipif(
sys.platform == "win32", reason="runtime_env unsupported on Windows.")
def test_decorator_task(start_cluster):
cluster, address = start_cluster
ray.init(address)
@ -54,6 +56,8 @@ def test_decorator_task(start_cluster):
assert ray.get(f.remote()) == "bar"
@pytest.mark.skipif(
sys.platform == "win32", reason="runtime_env unsupported on Windows.")
def test_decorator_actor(start_cluster):
cluster, address = start_cluster
ray.init(address)
@ -67,6 +71,8 @@ def test_decorator_actor(start_cluster):
assert ray.get(a.g.remote()) == "bar"
@pytest.mark.skipif(
sys.platform == "win32", reason="runtime_env unsupported on Windows.")
def test_decorator_complex(start_cluster):
cluster, address = start_cluster
ray.init(address, runtime_env={"env_vars": {"foo": "job"}})
@ -121,8 +127,7 @@ def test_container_option_serialize():
@pytest.mark.skipif(
sys.platform == "win32",
reason="conda in runtime_env unsupported on Windows.")
sys.platform == "win32", reason="runtime_env unsupported on Windows.")
def test_invalid_conda_env(shutdown_only):
ray.init()
@ -156,6 +161,8 @@ def test_invalid_conda_env(shutdown_only):
assert (time.time() - start) < (first_time / 2.0)
@pytest.mark.skipif(
sys.platform == "win32", reason="runtime_env unsupported on Windows.")
def test_no_spurious_worker_startup(shutdown_only):
"""Test that no extra workers start up during a long env installation."""
@ -223,7 +230,8 @@ def runtime_env_local_dev_env_var():
del os.environ["RAY_RUNTIME_ENV_LOCAL_DEV_MODE"]
@pytest.mark.skipif(sys.platform == "win32", reason="very slow on Windows.")
@pytest.mark.skipif(
sys.platform == "win32", reason="runtime_env unsupported on Windows.")
def test_runtime_env_no_spurious_resource_deadlock_msg(
runtime_env_local_dev_env_var, ray_start_regular, error_pubsub):
p = error_pubsub

View file

@ -52,27 +52,21 @@ def test_simple_env_modification_plugin(ray_start_regular):
}
}).remote()
if os.name != "nt":
# Windows does not have a command-line nice
output = ray.get(
f.options(
runtime_env={
"plugins": {
MY_PLUGIN_CLASS_PATH: {
"env_value": 42,
"tmp_file": tmp_file_path,
"tmp_content": "hello",
# See https://en.wikipedia.org/wiki/Nice_(Unix)
"prefix_command": "nice -n 19",
}
output = ray.get(
f.options(
runtime_env={
"plugins": {
MY_PLUGIN_CLASS_PATH: {
"env_value": 42,
"tmp_file": tmp_file_path,
"tmp_content": "hello",
# See https://en.wikipedia.org/wiki/Nice_(Unix)
"prefix_command": "nice -n 19",
}
}).remote())
}
}).remote())
assert output == {
"env_value": "42",
"tmp_content": "hello",
"nice": 19,
}
assert output == {"env_value": "42", "tmp_content": "hello", "nice": 19}
if __name__ == "__main__":