hiro/ray
1
0
Fork 0
mirror of https://github.com/vale981/ray synced 2025-03-06 02:21:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Unskip tests for Windows in test_output (#21775)

Browse source
This commit is contained in:
Gagandeep Singh 2022-01-25 22:55:01 +05:30 • committed by GitHub
parent d3d1e8559c
commit 395297a9bd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
python/ray/tests/test_output.py
View file

@ -12,7 +12,6 @@ from ray._private.test_utils import (run_string_as_driver_nonblocking,
run_string_as_driver)
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_autoscaler_infeasible():
script = """
import ray
@ -37,7 +36,6 @@ time.sleep(15)
assert "Error: No available node types can fulfill" in out_str
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_autoscaler_warn_deadlock():
script = """
import ray
@ -63,7 +61,6 @@ time.sleep(25)
assert "Warning: The following resource request cannot" in out_str
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_autoscaler_no_spam():
script = """
import ray
@ -89,7 +86,6 @@ ray.get([f.remote() for _ in range(15)])
assert "Tip:" not in err_str
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_fail_importing_actor(ray_start_regular, error_pubsub):
script = """
import os
@ -103,12 +99,15 @@ def temporary_helper_function():
return 1
'''
f = tempfile.NamedTemporaryFile(suffix=".py")
f.write(temporary_python_file.encode("ascii"))
f = tempfile.NamedTemporaryFile("w+", suffix=".py", prefix="_", delete=True)
f_name = f.name
f.close()
f = open(f_name, "w+")
f.write(temporary_python_file)
f.flush()
directory = os.path.dirname(f.name)
directory = os.path.dirname(f_name)
# Get the module name and strip ".py" from the end.
module_name = os.path.basename(f.name)[:-3]
module_name = os.path.basename(f_name)[:-3]
sys.path.append(directory)
module = __import__(module_name)
@ -130,7 +129,6 @@ a = Foo.remote()
assert "RuntimeError: The actor with name Foo failed to import" in err_str
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_fail_importing_task(ray_start_regular, error_pubsub):
script = """
import os
@ -144,12 +142,15 @@ def temporary_helper_function():
return 1
'''
f = tempfile.NamedTemporaryFile(suffix=".py")
f.write(temporary_python_file.encode("ascii"))
f = tempfile.NamedTemporaryFile("w+", suffix=".py", prefix="_", delete=True)
f_name = f.name
f.close()
f = open(f_name, "w+")
f.write(temporary_python_file)
f.flush()
directory = os.path.dirname(f.name)
directory = os.path.dirname(f_name)
# Get the module name and strip ".py" from the end.
module_name = os.path.basename(f.name)[:-3]
module_name = os.path.basename(f_name)[:-3]
sys.path.append(directory)
module = __import__(module_name)
@ -196,7 +197,6 @@ ray.get(foo.remote("abc", "def"))
assert err_str_sec_last.endswith("def")
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_core_worker_error_message():
script = """
import ray
@ -215,7 +215,6 @@ ray._private.utils.push_error_to_driver(
assert "Hello there" in err_str, err_str
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_disable_driver_logs_breakpoint():
script = """
import time
@ -256,7 +255,6 @@ ray.util.rpdb._driver_set_trace() # This should disable worker logs.
# TODO(ekl) nice to test resuming logs too, but it's quite complicated
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
@pytest.mark.parametrize("file", ["stdout", "stderr"])
def test_multi_stdout_err(file):
if file == "stdout":
@ -293,12 +291,12 @@ ray.get(baz.remote())
else:
out_str = proc.stderr.read().decode("ascii")
out_str = "".join(out_str.splitlines())
assert "(foo pid=" in out_str, out_str
assert "(bar pid=" in out_str, out_str
assert "(baz pid=" in out_str, out_str
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
@pytest.mark.parametrize("file", ["stdout", "stderr"])
def test_actor_stdout(file):
if file == "stdout":
@ -338,15 +336,15 @@ ray.get(b.f.remote())
out_str = proc.stdout.read().decode("ascii")
else:
out_str = proc.stderr.read().decode("ascii")
print(out_str)
out_str = "".join(out_str.splitlines())
assert "hi" in out_str, out_str
assert "(Actor1 pid=" in out_str, out_str
assert "bye" in out_str, out_str
assert re.search("Actor2 pid=.*init", out_str), out_str
assert not re.search("ActorX pid=.*init", out_str), out_str
assert re.search("ActorX pid=.*bye", out_str), out_str
assert not re.search("Actor2 pid=.*bye", out_str), out_str
assert re.search("Actor2 pid=.*bye", out_str), out_str
def test_output():