From 333f324b885999376ab052bf2961a43f62984297 Mon Sep 17 00:00:00 2001
From: architkulkarni <architkulkarni@users.noreply.github.com>
Date: Thu, 10 Sep 2020 15:54:37 -0700
Subject: [PATCH] Run Serve Tests on Windows (#10682)

---
 ci/travis/ci.sh                                    |  1 +
 python/ray/serve/examples/doc/tutorial_sklearn.py  | 14 ++++++++++----
 .../ray/serve/examples/doc/tutorial_tensorflow.py  |  5 +++--
 3 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/ci/travis/ci.sh b/ci/travis/ci.sh
index 8ad938525..8ded407e9 100755
--- a/ci/travis/ci.sh
+++ b/ci/travis/ci.sh
@@ -137,6 +137,7 @@ test_python() {
   if [ "${OSTYPE}" = msys ]; then
     pathsep=";"
     args+=(
+      python/ray/serve/...
       python/ray/tests/...
       -python/ray/tests:test_advanced_2
       -python/ray/tests:test_advanced_3  # test_invalid_unicode_in_worker_log() fails on Windows
diff --git a/python/ray/serve/examples/doc/tutorial_sklearn.py b/python/ray/serve/examples/doc/tutorial_sklearn.py
index 392493d29..976f883a2 100644
--- a/python/ray/serve/examples/doc/tutorial_sklearn.py
+++ b/python/ray/serve/examples/doc/tutorial_sklearn.py
@@ -6,6 +6,8 @@ import pickle
 import json
 import numpy as np
 import requests
+import os
+import tempfile
 
 from sklearn.datasets import load_iris
 from sklearn.ensemble import GradientBoostingClassifier
@@ -32,9 +34,13 @@ model.fit(train_x, train_y)
 print("MSE:", mean_squared_error(model.predict(val_x), val_y))
 
 # Save the model and label to file
-with open("/tmp/iris_model_logistic_regression.pkl", "wb") as f:
+MODEL_PATH = os.path.join(tempfile.gettempdir(),
+                          "iris_model_logistic_regression.pkl")
+LABEL_PATH = os.path.join(tempfile.gettempdir(), "iris_labels.json")
+
+with open(MODEL_PATH, "wb") as f:
     pickle.dump(model, f)
-with open("/tmp/iris_labels.json", "w") as f:
+with open(LABEL_PATH, "w") as f:
     json.dump(target_names.tolist(), f)
 # __doc_train_model_end__
 
@@ -42,9 +48,9 @@ with open("/tmp/iris_labels.json", "w") as f:
 # __doc_define_servable_begin__
 class BoostingModel:
     def __init__(self):
-        with open("/tmp/iris_model_logistic_regression.pkl", "rb") as f:
+        with open(MODEL_PATH, "rb") as f:
             self.model = pickle.load(f)
-        with open("/tmp/iris_labels.json") as f:
+        with open(LABEL_PATH) as f:
             self.label_list = json.load(f)
 
     def __call__(self, flask_request):
diff --git a/python/ray/serve/examples/doc/tutorial_tensorflow.py b/python/ray/serve/examples/doc/tutorial_tensorflow.py
index 27d95ff78..71f974697 100644
--- a/python/ray/serve/examples/doc/tutorial_tensorflow.py
+++ b/python/ray/serve/examples/doc/tutorial_tensorflow.py
@@ -3,13 +3,14 @@
 from ray import serve
 
 import os
+import tempfile
 import numpy as np
 import requests
 # __doc_import_end__
 # yapf: enable
 
 # __doc_train_model_begin__
-TRAINED_MODEL_PATH = "/tmp/mnist_model.h5"
+TRAINED_MODEL_PATH = os.path.join(tempfile.gettempdir(), "mnist_model.h5")
 
 
 def train_and_save_model():
@@ -69,7 +70,7 @@ class TFMnistModel:
 
 # __doc_deploy_begin__
 client = serve.start()
-client.create_backend("tf:v1", TFMnistModel, "/tmp/mnist_model.h5")
+client.create_backend("tf:v1", TFMnistModel, TRAINED_MODEL_PATH)
 client.create_endpoint("tf_classifier", backend="tf:v1", route="/mnist")
 # __doc_deploy_end__