Unskipped tests for Windows in test_client.py (#21824)

All the tests in `test_client.py` pass on Windows without issues, so unskipping them here.
This commit is contained in:
Gagandeep Singh 2022-01-25 12:21:54 +05:30 committed by GitHub
parent bc55a958c4
commit 290f3172ad
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -34,7 +34,6 @@ def test_client_context_manager(ray_start_regular_shared, connect_to_client):
assert not ray.util.client.ray.is_connected()
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_client_thread_safe(call_ray_stop_only):
import ray
ray.init(num_cpus=2)
@ -94,7 +93,6 @@ def test_client_mode_hook_thread_safe(ray_start_regular_shared):
) is True, "Threaded disable_client_hook failed to re-enable"
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_interrupt_ray_get(call_ray_stop_only):
import ray
ray.init(num_cpus=2)
@ -126,7 +124,6 @@ def test_interrupt_ray_get(call_ray_stop_only):
assert ray.get(fast.remote()) == "ok"
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_get_list(ray_start_regular_shared):
with ray_start_client_server() as ray:
@ -156,7 +153,6 @@ def test_get_list(ray_start_regular_shared):
assert get_count == 1
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_real_ray_fallback(ray_start_regular_shared):
with ray_start_client_server() as ray:
@ -177,7 +173,6 @@ def test_real_ray_fallback(ray_start_regular_shared):
assert len(nodes) == 1, nodes
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_nested_function(ray_start_regular_shared):
with ray_start_client_server() as ray:
@ -192,7 +187,6 @@ def test_nested_function(ray_start_regular_shared):
assert ray.get(g.remote()) == "OK"
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_put_get(ray_start_regular_shared):
with ray_start_client_server() as ray:
objectref = ray.put("hello world")
@ -211,7 +205,6 @@ def test_put_get(ray_start_regular_shared):
assert ray.get(list_put) == [1, 2, 3]
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_put_failure_get(ray_start_regular_shared):
with ray_start_client_server() as ray:
@ -230,7 +223,6 @@ def test_put_failure_get(ray_start_regular_shared):
assert ray.get(ray.put(100)) == 100
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_wait(ray_start_regular_shared):
with ray_start_client_server() as ray:
objectref = ray.put("hello world")
@ -259,7 +251,6 @@ def test_wait(ray_start_regular_shared):
ray.wait(["blabla"])
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_remote_functions(ray_start_regular_shared):
with ray_start_client_server() as ray:
SignalActor = create_remote_signal_actor(ray)
@ -318,7 +309,6 @@ def test_remote_functions(ray_start_regular_shared):
assert len(res[0]) == 1 and res[1] == []
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_function_calling_function(ray_start_regular_shared):
with ray_start_client_server() as ray:
@ -335,7 +325,6 @@ def test_function_calling_function(ray_start_regular_shared):
assert ray.get(f.remote()) == "OK"
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_basic_actor(ray_start_regular_shared):
with ray_start_client_server() as ray:
@ -368,7 +357,6 @@ def test_basic_actor(ray_start_regular_shared):
assert ray.get(r2) == 3
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_pass_handles(ray_start_regular_shared):
"""Test that passing client handles to actors and functions to remote actors
in functions (on the server or raylet side) works transparently to the
@ -432,7 +420,6 @@ def test_pass_handles(ray_start_regular_shared):
4)) == local_fact(4)
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_basic_log_stream(ray_start_regular_shared):
with ray_start_client_server() as ray:
log_msgs = []
@ -455,7 +442,6 @@ def test_basic_log_stream(ray_start_regular_shared):
(msg.find("put") >= 0 for msg in logs_with_id)), logs_with_id
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_stdout_log_stream(ray_start_regular_shared):
with ray_start_client_server() as ray:
log_msgs = []
@ -480,7 +466,6 @@ def test_stdout_log_stream(ray_start_regular_shared):
assert num_hello == 2, f"Invalid logs: {log_msgs}"
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_serializing_exceptions(ray_start_regular_shared):
with ray_start_client_server() as ray:
with pytest.raises(
@ -488,7 +473,6 @@ def test_serializing_exceptions(ray_start_regular_shared):
ray.get_actor("abc")
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_invalid_task(ray_start_regular_shared):
with ray_start_client_server() as ray:
@ -504,7 +488,6 @@ def test_invalid_task(ray_start_regular_shared):
ray.get(ref)
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_create_remote_before_start(ray_start_regular_shared):
"""Creates remote objects (as though in a library) before
starting the client.
@ -529,7 +512,6 @@ def test_create_remote_before_start(ray_start_regular_shared):
assert ray.get(a.doit.remote()) == "foo"
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_basic_named_actor(ray_start_regular_shared):
"""Test that ray.get_actor() can create and return a detached actor.
"""
@ -594,7 +576,6 @@ def test_error_serialization(ray_start_regular_shared):
ray.get(g.remote())
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
def test_internal_kv(ray_start_regular_shared):
with ray_start_client_server() as ray:
assert ray._internal_kv_initialized()
@ -656,7 +637,6 @@ def test_dataclient_server_drop(ray_start_regular_shared):
time.sleep(3)
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
@patch.dict(os.environ, {"RAY_ENABLE_AUTO_CONNECT": "0"})
def test_client_gpu_ids(call_ray_stop_only):
import ray
@ -717,7 +697,6 @@ def test_object_ref_cleanup():
assert "Exception ignored in" not in result
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
@pytest.mark.parametrize(
"call_ray_start",
["ray start --head --ray-client-server-port 25552 --port 0"],