hiro/ray
1
0
Fork 0
mirror of https://github.com/vale981/ray synced 2025-03-06 10:31:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use thread local random number generator (#20708)

Browse source
This commit is contained in:
Philipp Moritz 2021-11-27 15:44:44 -08:00 • committed by GitHub
parent 116bda8f05
commit 15a51b7c65
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/ray/util/util.h
View file

@ -202,12 +202,7 @@ template <typename T>
void FillRandom(T *data) { void FillRandom(T *data) {
RAY_CHECK(data != nullptr); RAY_CHECK(data != nullptr);
// NOTE(pcm): The right way to do this is to have one absl::BitGen per thread_local absl::BitGen generator;
// thread (using the thread_local keyword), but that's not supported on
// older versions of macOS (see https://stackoverflow.com/a/29929949)
static std::mutex random_engine_mutex;
std::lock_guard<std::mutex> lock(random_engine_mutex);
static absl::BitGen generator;
for (size_t i = 0; i < data->size(); i++) { for (size_t i = 0; i < data->size(); i++) {
(*data)[i] = static_cast<uint8_t>( (*data)[i] = static_cast<uint8_t>(
absl::Uniform(generator, 0, std::numeric_limits<uint8_t>::max())); absl::Uniform(generator, 0, std::numeric_limits<uint8_t>::max()));