From 12100015d9bfead2d3687c97bb0790231b8531f3 Mon Sep 17 00:00:00 2001
From: mwtian <81660174+mwtian@users.noreply.github.com>
Date: Wed, 13 Oct 2021 20:20:08 -0700
Subject: [PATCH] [Lint] Disable `modernize-use-override` (#19368)

This lint rule cannot apply only to changed lines because currently Ray has `-Winconsistent-missing-override` as a build flag. Either all or none of member functions from a derived class can have the `override` / `final` annocation.
---
 .clang-tidy | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.clang-tidy b/.clang-tidy
index 607f19902..a9d4671b3 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -11,6 +11,7 @@
 # -modernize-use-emplace (more subtle behavior)
 # -modernize-use-nodiscard (too much noise)
 # -modernize-use-trailing-return-type (inconsistent style)
+# -modernize-use-override (TODO(mwtian): re-enable after fixing existing derived classes)
 # -modernize-avoid-bind (incorrect conversion)
 # -modernize-loop-convert (more subtle behavior)
 # -modernize-replace-disallow-copy-and-assign-macro (inconsistent style)
@@ -42,6 +43,7 @@ Checks: >
   -modernize-replace-disallow-copy-and-assign-macro,
   -modernize-make-unique,
   -modernize-make-shared,
+  -modernize-use-override,
   performance-*,
   readability-avoid-const-params-in-decls,
   readability-braces-around-statements,