From 11c9b1779d475f6f1d55ef63a4341d74cfb631a3 Mon Sep 17 00:00:00 2001 From: Amr Farid Date: Sat, 20 Aug 2022 15:53:55 +0200 Subject: [PATCH] expose imagePullSecret to values.yaml (#27537) --- deploy/charts/ray/Chart.yaml | 2 +- deploy/charts/ray/templates/raycluster.yaml | 4 ++++ deploy/charts/ray/values.yaml | 2 ++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/deploy/charts/ray/Chart.yaml b/deploy/charts/ray/Chart.yaml index b2148b1ac..f2d1a1dd4 100644 --- a/deploy/charts/ray/Chart.yaml +++ b/deploy/charts/ray/Chart.yaml @@ -4,7 +4,7 @@ description: A Helm chart for deployments of Ray on Kubernetes. type: application # Chart version. -version: 0.1.0 +version: 0.2.0 # Ray version. appVersion: "latest" diff --git a/deploy/charts/ray/templates/raycluster.yaml b/deploy/charts/ray/templates/raycluster.yaml index d968513ca..09a04016a 100644 --- a/deploy/charts/ray/templates/raycluster.yaml +++ b/deploy/charts/ray/templates/raycluster.yaml @@ -90,6 +90,10 @@ spec: {{- if $.Values.serviceAccountName }} serviceAccountName: {{ $.Values.serviceAccountName }} {{- end }} + {{- with $.Values.imagePullSecrets }} + imagePullSecrets: + {{- toYaml . | nindent 10 }} + {{- end }} {{- end }} # Commands to start Ray on the head node. You don't need to change this. # Note dashboard-host is set to 0.0.0.0 so that Kubernetes can port forward. diff --git a/deploy/charts/ray/values.yaml b/deploy/charts/ray/values.yaml index 59abe8cf7..89e377117 100644 --- a/deploy/charts/ray/values.yaml +++ b/deploy/charts/ray/values.yaml @@ -18,6 +18,8 @@ headPodType: rayHeadType # serviceAccountName is used for the Ray head and each Ray worker. # It can be set to your particular service account instead of using the default. # serviceAccountName: ... +# imagePullSecrets is used to authenticate to private docker registry, when you have a custom image. +imagePullSecrets: [] # podTypes is the list of pod configurations available for use as Ray nodes. podTypes: # The key for each podType is a user-defined string.