hiro/ray
1
0
Fork 0
mirror of https://github.com/vale981/ray synced 2025-03-06 10:31:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Re-enabling tests from test_basic (#19384)

Browse source 
Why are these changes needed?
Related issue number
##19177

Quoting #19177 (comment) here,

The following tests fail when not skipped,

=================================== short test summary info ====================================
FAILED python\ray\tests\test_basic.py::test_user_setup_function - subprocess.CalledProcessErro...
FAILED python\ray\tests\test_basic.py::test_disable_cuda_devices - subprocess.CalledProcessErr...
FAILED python\ray\tests\test_basic.py::test_wait_timing - assert (1634209333.6099107 - 1634209...

Results (395.22s):
      36 passed
       3 failed
         - ray\tests/test_basic.py:197 test_user_setup_function
         - ray\tests/test_basic.py:220 test_disable_cuda_devices
         - ray\tests/test_basic.py:265 test_wait_timing
=================================== short test summary info ====================================
FAILED python\ray\tests\test_basic_3.py::test_fair_queueing - AssertionError: 23

Results (198.33s):
       1 failed
         - ray\tests/test_basic_3.py:169 test_fair_queueing
The following test passed when not skipped. Opening a PR to verify that.

def test_oversized_function(ray_start_shared_local_modes)
This commit is contained in:
Gagandeep Singh 2021-10-16 02:32:57 +05:30 • committed by GitHub
parent bb38c5cb1f
commit 07064cddf9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
python/ray/tests/test_basic.py
View file

@ -264,7 +264,6 @@ def test_put_get(shutdown_only):
assert value_before == value_after
@pytest.mark.skipif(sys.platform != "linux", reason="Failing on Windows")
def test_wait_timing(shutdown_only):
ray.init(num_cpus=2)
@ -274,9 +273,9 @@ def test_wait_timing(shutdown_only):
future = f.remote()
start = time.time()
start = time.perf_counter()
ready, not_ready = ray.wait([future], timeout=0.2)
assert 0.2 < time.time() - start < 0.3
assert 0.2 < time.perf_counter() - start < 0.4
assert len(ready) == 0
assert len(not_ready) == 1
@ -639,9 +638,8 @@ def test_args_named_and_star(ray_start_shared_local_modes):
ray.get(remote_test_function.remote(local_method, actor_method))
@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows")
def test_oversized_function(ray_start_shared_local_modes):
bar = np.zeros(100 * 1024 * 1024)
bar = np.zeros(100 * 1024 * 125)
@ray.remote
class Actor: